chore(ci): Upgrade performance test apps to React Native 0.85.1#6088
Open
chore(ci): Upgrade performance test apps to React Native 0.85.1#6088
Conversation
Closes #4426 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
Contributor
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5fe1c6c+dirty | 401.62 ms | 445.28 ms | 43.66 ms |
| 2c735cc+dirty | 414.09 ms | 438.47 ms | 24.38 ms |
| 3d377b5+dirty | 406.18 ms | 453.52 ms | 47.34 ms |
| 4b87b12+dirty | 421.82 ms | 413.60 ms | -8.22 ms |
| 04207c4+dirty | 459.19 ms | 518.54 ms | 59.35 ms |
| 7ac3378+dirty | 404.78 ms | 439.84 ms | 35.06 ms |
| 3ce5254+dirty | 410.57 ms | 448.48 ms | 37.91 ms |
| 5c1e987+dirty | 423.52 ms | 471.64 ms | 48.12 ms |
| 3817909+dirty | 406.67 ms | 416.58 ms | 9.91 ms |
| a50b33d+dirty | 500.81 ms | 532.11 ms | 31.30 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5fe1c6c+dirty | 43.75 MiB | 48.14 MiB | 4.39 MiB |
| 2c735cc+dirty | 43.75 MiB | 48.08 MiB | 4.33 MiB |
| 3d377b5+dirty | 43.75 MiB | 48.14 MiB | 4.39 MiB |
| 4b87b12+dirty | 43.75 MiB | 48.14 MiB | 4.39 MiB |
| 04207c4+dirty | 43.75 MiB | 48.12 MiB | 4.37 MiB |
| 7ac3378+dirty | 43.75 MiB | 48.13 MiB | 4.37 MiB |
| 3ce5254+dirty | 43.75 MiB | 48.12 MiB | 4.37 MiB |
| 5c1e987+dirty | 43.75 MiB | 48.08 MiB | 4.33 MiB |
| 3817909+dirty | 43.75 MiB | 48.08 MiB | 4.33 MiB |
| a50b33d+dirty | 43.75 MiB | 48.08 MiB | 4.33 MiB |
Contributor
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5fe1c6c+dirty | 365.84 ms | 408.62 ms | 42.78 ms |
| 2c735cc+dirty | 435.20 ms | 459.48 ms | 24.28 ms |
| 3d377b5+dirty | 425.38 ms | 440.67 ms | 15.30 ms |
| 4b87b12+dirty | 356.23 ms | 399.86 ms | 43.63 ms |
| 04207c4+dirty | 395.40 ms | 456.55 ms | 61.15 ms |
| 7ac3378+dirty | 410.67 ms | 442.60 ms | 31.92 ms |
| 3ce5254+dirty | 373.90 ms | 427.84 ms | 53.94 ms |
| 5c1e987+dirty | 444.71 ms | 475.13 ms | 30.42 ms |
| 3817909+dirty | 357.52 ms | 391.52 ms | 34.00 ms |
| a50b33d+dirty | 353.21 ms | 398.48 ms | 45.27 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5fe1c6c+dirty | 43.94 MiB | 49.00 MiB | 5.06 MiB |
| 2c735cc+dirty | 43.94 MiB | 48.94 MiB | 5.00 MiB |
| 3d377b5+dirty | 43.94 MiB | 49.00 MiB | 5.06 MiB |
| 4b87b12+dirty | 43.94 MiB | 49.00 MiB | 5.06 MiB |
| 04207c4+dirty | 43.94 MiB | 48.98 MiB | 5.04 MiB |
| 7ac3378+dirty | 43.94 MiB | 48.99 MiB | 5.05 MiB |
| 3ce5254+dirty | 43.94 MiB | 48.98 MiB | 5.04 MiB |
| 5c1e987+dirty | 43.94 MiB | 48.94 MiB | 5.00 MiB |
| 3817909+dirty | 43.94 MiB | 48.94 MiB | 5.00 MiB |
| a50b33d+dirty | 43.94 MiB | 48.94 MiB | 5.00 MiB |
The podspec's node resolution finds packages/core/node_modules/react-native (0.80.1) instead of the perf test app's (0.85.1) due to yarn workspace symlink resolution. This causes NEW_HERMES_RUNTIME to not be defined, and the old Hermes static profiling API (removed in RN 0.85) to be compiled. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The RN 0.80 to 0.85 upgrade increased the Sentry-vs-plain iOS binary size diff from ~1.44 MiB to ~1.51 MiB. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
@sentry review |
Contributor
Author
|
@cursor review |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit fbd7702. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Upgrades the performance test apps (TestAppPlain/TestAppSentry) from React Native 0.80.2 to 0.85.1, aligning them with the RN version used in the e2e test matrix.
Changes across both apps:
react-nativereact@react-native-community/cli*@react-native/{babel-preset,metro-config,typescript-config}buildToolsVersioncompileSdkVersion/targetSdkVersionAdditional changes:
edgeToEdgeEnabled=falsetogradle.properties(new RN 0.85 template property)nkfgem to Gemfiles (Ruby 3.4 compatibility, per RN 0.85 template)REACT_NATIVE_NODE_MODULES_DIRfor perf test iOS builds to fix podspec RN version detection in the yarn workspace (the podspec was resolvingpackages/core/node_modules/react-nativeat 0.80.1 instead of the test app's 0.85.1, causing the old Hermes profiling API to be compiled)Notes:
newArchEnabledis intentionally kept asfalse(default). CI toggles it for the new-arch matrix variant.💡 Motivation and Context
Closes #4426
This is a followup on #4414 which bumped the apps from RN 0.70.6 to 0.70.15 as a minimal fix. Upgrading to 0.85.1 brings the perf test apps in line with the e2e test matrix and modern Android/iOS tooling.
💚 How did you test it?
CI — monitoring the metrics job for binary size and startup time regressions.
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog