build(deps): update reqwest from v0.12.25 to v0.13.1#958
build(deps): update reqwest from v0.12.25 to v0.13.1#958AlexTMjugador wants to merge 12 commits intogetsentry:szokeasaurusrex/update-cargofrom
reqwest from v0.12.25 to v0.13.1#958Conversation
This fixes a failing doctest.
Run `cargo update` to bump all dependencies to the latest versions.
…pdate # Conflicts: # CHANGELOG.md # Cargo.lock
szokeasaurusrex
changed the base branch from
master
to
szokeasaurusrex/update-cargo
This dependency bump is a breaking change. https://docs.rs/sentry/latest/sentry/transports/struct.ReqwestHttpTransport.html#method.with_client
szokeasaurusrex
force-pushed
the
szokeasaurusrex/update-cargo
branch
from
0cb5f31 to
fb9917f
Compare
…pdate # Conflicts: # Cargo.lock
szokeasaurusrex
left a comment
szokeasaurusrex
left a comment
There was a problem hiding this comment.
Lgtm! Thank you @AlexTMjugador 🙏
@Dav1dde can you also take a look? I have based this on top of my cargo update in #968, it does not seem like we are duplicating very many dependencies in the Cargo.lock with that change.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/update-cargo
branch
from
fb9917f to
95aba0b
Compare
|
I noticed that this PR has been closed. What does that mean for the plans to update the |
I second this concern @szokeasaurusrex Was it closed by accident? The dependency version of |
|
Indeed, this appears to have been closed automatically, perhaps because the base branch has been closed. I will take a look! We certainly want to do this upgrade. I will see if I can reopen the PR (currently the button to do so is greyed out, perhaps because the base branch no longer exists); otherwise, I will open a new PR |
|
Thank you for bringing this to my attention! |
|
@AlexTMjugador @Iskander508 I have opened #998, which supersedes this PR |
4 participants
Description
This PR updates
reqwestfrom v0.12.25 to v0.13.1. From a user perspective, the most noteworthy change is that it switches the defaultrustlsprovider fromringtoaws-lc-rs. This bringsreqwestin line with the broader ecosystem's move towardaws-lc-rsas the default and increases the likelihood that users will no longer need to include multiple TLS implementations in their binaries.Stacked on #968
Issues
This resolves a personal goal of mine, as a user, to remove
ringfrom my transitive dependency tree. However, it does not address an issue that was previously documented in this repository.