chore: Update tests for structured logs - #1224
Merged
Merged
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
Android's SetAttribute/RemoveAttribute on the subsystem are no-ops (sentry-java doesn't support global log attributes). These are tested in desktop tests only. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
tustanivsky
marked this pull request as ready for review
February 11, 2026 16:09
jpnurmi
approved these changes
Feb 13, 2026
mujacica
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing unit tests for
BeforeLogHandlerand log attributes had two major issues:Test stability and isolation: The tests required subsystem re-initialization mid-test (
InitializeWithSettings), which caused flakiness and interfered with subsequent tests. In some cases, running these tests left the editor session in a broken state where the sample app became unusable in Play Mode (PIE).Lack of end-to-end validation: The tests were shallow: they only verified that the handler was invoked and received the correct data in-process. They never validated that the modified log actually reached Sentry with the expected attributes. As a result, a passing unit test did not guarantee the feature worked end-to-end.
Key changes:
BeforeLogHandlerand global log attributesBeforeLogHandleradding and removing attributesSentrySubsystem->SetAttribute()attached to logsSentrySubsystem->RemoveAttribute()not appearing on logsCppBeforeLogHandlerto the sample app, wired via-ini:settings override in testsRunLogTest()to exercise global attribute set/remove before sending the logDepends on:
Fieldsparameter to log query functions app-runner#37Related items:
#skip-changelog