chore: Add integration tests for tracing - #1234
Merged
Merged
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
tustanivsky
marked this pull request as ready for review
February 17, 2026 13:31
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
mujacica
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing unit tests for tracing had two issues:
SentrySubsystem.spec.cpp(transaction lifecycle) andSentryTraceSampling.spec.cpp(custom trace sampler) calledClose()+InitializeWithSettings()inBeforeEach, which caused flakiness and interfered with other tests in the automation suite.IsFinished()returns true afterFinish()). They never validated that the transaction and its spans actually reached Sentry with the expected data.Key changes:
removes tags and data on both, and outputs the trace ID for lookup
CppTraceSamplerto the sample app that accepts transactions matching the test name and discards all others,exercising the custom
TracesSamplerpipelineStartTransactionWithContextAndOptionswith custom sampling context to cover the full transaction creation pathSentrySubsystem.spec.cpp,SentryTraceSampling.spec.cpp, andSentryTraceSamplingHandler.hunit tests replaced by e2e coverageapp-runnerto includeGet-SentrySpansandGet-SentryTestTransactionhelpers that query the spans datasetREADMEDepends on:
Related items:
#skip-changelog