fix(ourlogs): resolve received time in the timestamp hover tooltip - #121477
Draft
JoshuaKGoldberg wants to merge 1 commit into
Draft
fix(ourlogs): resolve received time in the timestamp hover tooltip#121477JoshuaKGoldberg wants to merge 1 commit into
JoshuaKGoldberg wants to merge 1 commit into
Conversation
The trace item details endpoint only aliases the observed timestamp to `observed_timestamp` when it comes back as an int. It is stored as a string, so it arrives as `sentry.observed_timestamp_nanos` instead, which the tooltip never looked up. In the expanded log details and the metrics sample details, whose attribute maps are keyed by the raw response names, "Received" therefore spun on a loading indicator forever. The tooltip now reads either name, and only renders the "Received" row once it has a value instead of falling back to an unbounded spinner. Fixes LOGS-937
JoshuaKGoldberg
changed the title
JoshuaKGoldberg
force-pushed
the
joshgoldberg/logs-937-timestamp-loading-forever-in-hover
branch
from
August 6, 2026 20:25
368f560 to
a50d323
Compare
Member
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a50d323. Configure here.
| setIsPending(false); | ||
| }, | ||
| () => {} | ||
| () => setIsPending(false) |
Contributor
There was a problem hiding this comment.
Pending flag can stick forever
Medium Severity
isPending starts as true and is only cleared when fetchQuery settles. If prefetch returns early without a project slug, or the hover timeout is cleared before the request starts (common when moving into the isHoverable timestamp tooltip), isTraceItemDetailsPending stays true and the Received row can spin forever again.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit a50d323. Configure here.
JoshuaKGoldberg
force-pushed
the
joshgoldberg/logs-937-timestamp-loading-forever-in-hover
branch
from
August 6, 2026 20:48
a50d323 to
368f560
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Received" row in the log timestamp hover tooltip spun on a loading indicator forever in the expanded log details.
observed_timestampis declared withsearch_type="number"but stored as a string, andLOGS_INTERNAL_TO_PUBLIC_ALIAS_MAPPINGSis keyed bysearch_type. The trace item details endpoint looks the alias up using the type of the value it actually got back ("string") so it misses the"number"` bucket and falls back to emitting the internal name:{"name": "sentry.observed_timestamp_nanos", "type": "str", "value": "1786046484244158487"}The log table row works because it maps that internal name in while merging the prefetched attributes. But the tooltip only read the
observed_timestampalias. The expanded log details key their attribute map by the raw response names, so the lookup missed and the placeholder spinner added in #115505 had nothing to resolve to.The tooltip now accepts either name. It also stops spinning once the trace item details request has settled, so a log that just misses the attribute no longer leaves a spinner up forever.
Closes LOGS-937.