Skip to content

fix(issue-details): Remove linked pull request checks and review status #121484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
malwilley merged 3 commits into from
Aug 7, 2026
+20 −5
Merged

fix(issue-details): Remove linked pull request checks and review status #121484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92fb720
perf(issue-details): Skip linked pull request checks
malwilley Aug 6, 2026
45ee479
Remove unnecessary test
malwilley Aug 6, 2026
04f6973
Merge branch 'master' into malwilley/hide-linked-pr-checks
malwilley Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions static/app/components/group/externalIssuesList/linkedPullRequests.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ export function getLinkedPullRequestActivityIds(group: Group) {

interface LinkedPullRequestsProps {
group: Group;
showChecksAndReview?: boolean;
showEmptyState?: boolean;
}

Expand Down Expand Up @@ -231,23 +232,36 @@ function SeerAttributionAvatar() {
);
}

export function useLinkedPullRequests({group}: {group: Group}) {
export function useLinkedPullRequests({
group,
includeChecksAndReview = true,
}: {
group: Group;
includeChecksAndReview?: boolean;
}) {
const organization = useOrganization();

return useQuery(
apiOptions.as<LinkedPullRequestsResponse>()(
'/organizations/$organizationIdOrSlug/issues/$issueId/pull-requests/',
{
path: {organizationIdOrSlug: organization.slug, issueId: group.id},
query: {expand: 'checksAndReview'},
query: includeChecksAndReview ? {expand: 'checksAndReview'} : undefined,
staleTime: 30_000,
}
)
);
}

export function LinkedPullRequests({group, showEmptyState}: LinkedPullRequestsProps) {
const {data, isError, isPending} = useLinkedPullRequests({group});
export function LinkedPullRequests({
group,
showChecksAndReview = true,
showEmptyState,
}: LinkedPullRequestsProps) {
const {data, isError, isPending} = useLinkedPullRequests({
group,
includeChecksAndReview: showChecksAndReview,
});
const activityPullRequestIds = getLinkedPullRequestActivityIds(group);

if (isError) {
Expand Down
3 changes: 2 additions & 1 deletion static/app/views/issueDetails/sidebar/externalIssueSidebarList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ interface Props {
export function ExternalIssueSidebarList({event, group}: Props) {
const externalIssueData = useGroupExternalIssues({group, event});
const {data: linkedPullRequestsData, isPending: isLinkedPullRequestsLoading} =
useLinkedPullRequests({group});
useLinkedPullRequests({group, includeChecksAndReview: false});
const hasLinkedPullRequestActivity = getLinkedPullRequestActivityIds(group).size > 0;
const showEmptyIssueTrackerAction =
!externalIssueData.isLoading &&
Expand Down Expand Up @@ -60,6 +60,7 @@ export function ExternalIssueSidebarList({event, group}: Props) {
<ErrorBoundary customComponent={null}>
<LinkedPullRequests
group={group}
showChecksAndReview={false}
showEmptyState={
!showEmptyIssueTrackerAction &&
!externalIssueData.isLoading &&
Expand Down
Loading