Skip to content

fix(sentry-apps): Prevent MissingSchema with empty webhook_url #121494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −1
Open

fix(sentry-apps): Prevent MissingSchema with empty webhook_url #121494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/sentry/utils/sentry_apps/webhooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,8 @@ def send_and_save_webhook_request(
org_id = app_platform_event.install.organization_id
slug = sentry_app.slug_for_metrics
url = url or sentry_app.webhook_url
if not url:
return Response()
lifecycle.add_extras(
{
"org_id": org_id,
Expand All @@ -266,7 +268,6 @@ def send_and_save_webhook_request(
}
)

assert url is not None
try:
owner_context = organization_service.get_organization_by_id(
id=sentry_app.owner_id,
Expand Down
Loading