fix(alerts): Show capped pagination counts as lower bounds - #121500
Open
sentry-junior[bot] wants to merge 5 commits into
Open
fix(alerts): Show capped pagination counts as lower bounds#121500sentry-junior[bot] wants to merge 5 commits into
sentry-junior[bot] wants to merge 5 commits into
Conversation
Co-Authored-By: Nick Meisenheimer <nicholas.meisenheimer@sentry.io>
github-actions
Bot
added
the
Scope: Frontend
souredoutlook
marked this pull request as ready for review
August 7, 2026 00:16
Co-Authored-By: Nick Meisenheimer <nicholas.meisenheimer@sentry.io>
souredoutlook
added
the
Trigger: getsentry tests
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Keep the lower-bound marker in the [total] slot so translations cannot leave the + stranded, without changing the shared pagination helper.
github-actions
Bot
removed
the
Trigger: getsentry tests
When pagination walks past the reported X-Hits count, treat the total as a lower bound even if X-Max-Hits is missing from the response. Co-Authored-By: Nick Meisenheimer <nicholas.meisenheimer@sentry.io>
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 749123f. Configure here.
OffsetPaginator omits X-Max-Hits, so early Alerts pages never knew the 1000-row ceiling. Default maxHits to 1000 so first-page totals can still render as lower bounds. Co-Authored-By: Nick Meisenheimer <nicholas.meisenheimer@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show capped Alerts pagination totals as lower bounds instead of presenting the paginator's 1,000-row count ceiling as an exact total.
Scoped to the Alerts list only. The caption mirrors the Issues list pattern with local
tctandQueryCountin[total].Why the default ceiling fallback
OffsetPaginatorcounts hits but does not exposemax_hits, so production workflows responses omitX-Max-Hits. Without a fallback, early pages (including the first page) treatedX-Hits: 1000as exact. This list now defaultsmaxHitsto1000when the header is missing, and still treats deep pages pastX-Hitsas capped.Requested by Nick Meisenheimer.
--
View Junior Session [Sentry]