feat(replays): Let the deletion script select which steps it runs - #121501
Open
gggritso wants to merge 2 commits into
Open
feat(replays): Let the deletion script select which steps it runs#121501gggritso wants to merge 2 commits into
gggritso wants to merge 2 commits into
Conversation
`delete_replays` archives, deletes Seer summaries and deletes RRWeb blobs. Each step is now selectable, defaulting to on, so a caller that has already performed one of them by hand can skip it. Skipping the blob step also skips the legacy `ReplayRecordingSegment` cleanup, which lives inside `delete_replays_script_async`.
github-actions
Bot
added
the
Scope: Backend
Member
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 5cacf21. Configure here.
gggritso
marked this pull request as ready for review
August 7, 2026 04:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes each step of
delete_replaysindividually selectable.archive,delete_seer_dataanddelete_blobsare keyword-only and default toTrue, so every existing caller keeps its current behaviour.We sometimes perform one of these steps by hand, out of band, so it's useful to skip some steps (e.g., if we delete GCS contents manually).
getsentryside in https://github.com/getsentry/getsentry/pull/21408References REPLAY-971