fix(proguard): Accept mapping files without line number ranges#1898
Merged
Conversation
ProGuard/R8 mapping files that contain only class and method name mappings (no line number ranges) are valid and can still deobfuscate stacktraces. Previously these were rejected with "doesn't contain any line mappings", which prevented deobfuscation entirely. Fixes getsentry/sentry-java#5143 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
…chable Stale cached entries or unexpected malformed messages (e.g. decompression errors) would panic via unreachable!(). All malformed proguard files are invalid regardless of the specific error message. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Dav1dde
approved these changes
Mar 10, 2026
…ng unreachable" This reverts commit 5dbdeeb.
Mapping files without line info were previously cached as Malformed errors. Bumping the cache version ensures those stale entries are invalidated and the files get re-processed correctly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…info errors" This reverts commit 8841d2b.
…chable Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
has_line_info()check that rejected valid ProGuard mapping files lacking line number rangesNoLineInfoerror variant that was no longer neededProGuard/R8 mapping files without line number ranges are still useful for deobfuscating class and method names. Previously these were rejected as malformed.
Fixes getsentry/sentry-java#5143
Test plan
test_no_line_info_mappingcovers the full service path🤖 Generated with Claude Code