feat: add org avatar rule#135
Merged
strongs merged 2 commits intoJun 10, 2026
Merged
Conversation
lynnagara
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Org avatars are served from
/organization-avatar/:slug/:idinstead of/organizations/:slug/avatar, because cookie-less asset URLs need a static path prefix and the latter doesn't have one (the slug comes first). Synapse routes by cell, so it needs to learn how to resolve this new path shape to the org's cell.Fix:
Adds a slug-based locator route using the existing
cell_from_organizationresolver, which extracts the org slug from the captured{organization}segment and looks up its cell.notes:
/{organization}/*) because the same endpoint has a deprecated no-slug form, and this would match - incorrectly - with the wildcardRefs INFRENG-324