Skip to content

fix(ci): bump Playwright to ^1.60.0 to fix install hang on Node 24.16+ #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
constantinius merged 1 commit into from
Jun 29, 2026
Merged

fix(ci): bump Playwright to ^1.60.0 to fix install hang on Node 24.16+ #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions .github/workflows/daily-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,16 +99,8 @@ jobs:
npm ci
npm run build

- name: Install Playwright system dependencies
run: npx playwright install-deps chromium
env:
DEBIAN_FRONTEND: noninteractive
NEEDRESTART_MODE: a
timeout-minutes: 5

- name: Install Playwright browsers
run: npx playwright install chromium
timeout-minutes: 5
run: npx playwright install --with-deps chromium

@sentry sentry Bot Jun 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The playwright install command is missing environment variables (DEBIAN_FRONTEND, NEEDRESTART_MODE) needed to prevent interactive prompts, which can cause CI jobs to hang.
Severity: HIGH

Suggested Fix

Prepend the npx playwright install command with the necessary environment variables to prevent interactive prompts. For example: env DEBIAN_FRONTEND=noninteractive NEEDRESTART_MODE=a npx playwright install --with-deps chromium.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: .github/workflows/daily-tests.yml#L103

Potential issue: The consolidated `npx playwright install --with-deps chromium` command
removes the `DEBIAN_FRONTEND: noninteractive` and `NEEDRESTART_MODE: a` environment
variables. These variables were previously set to prevent interactive prompts from
`apt-get` and `needrestart` on Ubuntu runners, which can cause CI jobs to hang
indefinitely. While the PR fixes a separate hang issue related to file extraction in
Playwright, removing these environment variables re-introduces a risk of hangs during
the dependency installation step. This pattern is repeated in multiple workflow files.

Also affects:

  • .github/workflows/pr-tests.yml:96~96
  • .github/workflows/pr-tests.yml:197~197

Did we get this right? 👍 / 👎 to inform future reviews.


- name: Run tests
continue-on-error: true
Expand Down
20 changes: 2 additions & 18 deletions .github/workflows/pr-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,16 +92,8 @@ jobs:
npm ci
npm run build

- name: Install Playwright system dependencies
run: npx playwright install-deps chromium
env:
DEBIAN_FRONTEND: noninteractive
NEEDRESTART_MODE: a
timeout-minutes: 5

- name: Install Playwright browsers
run: npx playwright install chromium
timeout-minutes: 5
run: npx playwright install --with-deps chromium

- name: Run tests
id: run-tests
Expand Down Expand Up @@ -201,16 +193,8 @@ jobs:
npm ci
npm run build

- name: Install Playwright system dependencies
run: npx playwright install-deps chromium
env:
DEBIAN_FRONTEND: noninteractive
NEEDRESTART_MODE: a
timeout-minutes: 5

- name: Install Playwright browsers
run: npx playwright install chromium
timeout-minutes: 5
run: npx playwright install --with-deps chromium

- name: Run tests
id: run-tests
Expand Down
20 changes: 12 additions & 8 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"htm": "^3.1.1",
"log-update": "^7.0.2",
"nunjucks": "^3.2.4",
"playwright": "^1.49.1",
"playwright": "^1.60.0",
"prettier": "^3.8.1",
"vhtml": "^2.2.0",
"vite": "^6.0.11",
Expand Down
Loading