Skip to content

build(test-queues-module-manual): Migrate to uv and pyproject.toml #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericapisani merged 2 commits into from
May 21, 2026
Merged

build(test-queues-module-manual): Migrate to uv and pyproject.toml #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a68220
build(test-queues-module-manual): Migrate to uv and pyproject.toml
ericapisani May 21, 2026
bdcb2a5
fix python version
ericapisani May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test-queues-module-manual/.python-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.10.4
3.14
12 changes: 12 additions & 0 deletions test-queues-module-manual/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
[project]
name = "test-queues-module-manual"
version = "0"
requires-python = ">=3.12"

@sentry sentry Bot May 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The pyproject.toml file's requires-python constraint (>=3.12) conflicts with the pinned version in .python-version (3.10.4), causing uv run to fail.
Severity: HIGH

Suggested Fix

Align the Python version requirements. Either update the .python-version file to a version that satisfies >=3.12, or change the requires-python setting in pyproject.toml to ">=3.10.4" to match the pinned version.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: test-queues-module-manual/pyproject.toml#L4

Potential issue: The `pyproject.toml` file specifies `requires-python = ">=3.12"`, but
the project's `.python-version` file pins the Python interpreter to `3.10.4`. The `uv`
tool, used in `run.sh`, enforces that the environment's interpreter version satisfies
the `requires-python` constraint. When `uv run` is executed, it detects this version
mismatch and aborts with an incompatibility error, preventing the test script from
running.

Did we get this right? 👍 / 👎 to inform future reviews.


dependencies = [
"ipdb>=0.13.13",
"sentry-sdk",
]

[tool.uv.sources]
sentry-sdk = { path = "../../sentry-python", editable = true }
4 changes: 0 additions & 4 deletions test-queues-module-manual/requirements.txt
View file
Open in desktop

This file was deleted.

11 changes: 4 additions & 7 deletions test-queues-module-manual/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
#!/usr/bin/env bash

set -euo pipefail

reset

python -m venv .venv
source .venv/bin/activate

pip install -r requirements.txt
if ! command -v uv &> /dev/null; then
curl -LsSf https://astral.sh/uv/install.sh | sh
fi

python main.py
uv run python main.py
Comment on lines +5 to +9

@sentry sentry Bot May 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The script installs uv but fails to update the PATH in the current session, causing the subsequent uv command to fail.
Severity: HIGH

Suggested Fix

Explicitly update the PATH variable within the script after the installation step (e.g., export PATH="$HOME/.local/bin:$PATH") or invoke the uv binary using its absolute path.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: test-queues-module-manual/run.sh#L5-L9

Potential issue: The `run.sh` script attempts to install `uv` if it is not found.
However, the installation process modifies shell configuration files for future sessions
but does not update the `PATH` environment variable for the current, executing shell.
Because the script uses `set -e`, the subsequent call to `uv run python main.py` fails
with a "command not found" error, causing the script to exit. This will occur in any
environment that does not already have `uv` installed and in the `PATH`.

Loading