Cargo.toml - enable TLS on redis crate - #446
Conversation
|
@evanpurkhiser @aldy505 Any chance we could land this? I'm migrating my self-hosted stack to AWS ElastiCache Valkey Serverless, which requires TLS — without these features the redis crate panics at startup on I'm building against this branch locally to validate end-to-end and will follow up here with results. |
|
The changes in this PR alone are not enough, but I have a confirmed change working end-to-end against AWS ElastiCache Valkey Serverless (TLS-required, cluster-mode endpoint). Two additions on top of the current branch were needed to get rediss:// URLs actually connecting:
I also trimmed the Changes on top of this PR: Cargo.toml src/main.rs Adjust the |
|
@SmoshySmosh working it here #506 |
|
@aldy505 Thank you! I was thinking about submitting a PR but I can't use github at work 😅. |
Superseed this PR due to missing CI run #446 --------- Co-authored-by: Erik Holmqvist <66835855+zmarta-erik@users.noreply.github.com>
Hello,
We use a self hosted version of Sentry. In our setup we use Redis with TLS encryption (AWS Elasticache) which works well with other components of Sentry, but not uptime-checker.
Enabling support for TLS on the redis crate fixes this issue. For other methods of self hosting Redis, one might wish to enable 'tls-rustls-insecure' as well (to allow self signed certificates).
I did take a look at previous PRs and issues and I did not spot any previous mention of this, my bad if I overlooked something!