Skip to content

Use explicit @PathVariable names for reliable binding #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejfuhrer merged 2 commits into from
Jun 12, 2026
Merged

Use explicit @PathVariable names for reliable binding #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bfadb2
Enable -parameters compiler flag for reliable PathVariable binding
ondrejfuhrer Jun 12, 2026
bb5af45
Use explicit @PathVariable names instead of -parameters flag
ondrejfuhrer Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/getourguide/interview/controller/ActivitiesController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ public ResponseEntity<List<ActivityDto>> activities() {
}

@GetMapping("/activities/{id}")
public ResponseEntity<ActivityDto> activities(@PathVariable Long id) {
public ResponseEntity<ActivityDto> activities(@PathVariable("id") Long id) {
return ResponseEntity.ok(activityService.getActivities(id));
}

@GetMapping("/activities/search/{search}")
public ResponseEntity<List<ActivityDto>> activitiesSearch(@PathVariable String search) {
public ResponseEntity<List<ActivityDto>> activitiesSearch(@PathVariable("search") String search) {
return ResponseEntity.ok(activityService.searchActivities(search));
}
}
2 changes: 1 addition & 1 deletion src/main/java/com/getourguide/interview/controller/SupplierController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public ResponseEntity<List<Supplier>> suppliers() {
}

@GetMapping("/suppliers/search/{search}")
public ResponseEntity<List<Supplier>> suppliersSearch(@PathVariable String search) {
public ResponseEntity<List<Supplier>> suppliersSearch(@PathVariable("search") String search) {
var list = (List<Supplier>) entityManager.createNativeQuery("SELECT * FROM GETYOURGUIDE.SUPPLIER", Supplier.class).getResultList();
for(Supplier s: list) {
if(new StringBuilder().append(s.getName()).append(s.getAddress()).append(s.getZip()).append(s.getCity()).append(s.getCountry()).toString().contains(search)) {
Expand Down
Loading