Conversation
#845) The dep-bump fixture from #849 included `yarn.lock` and reported 27 seconds of LLM work for it. That's a bench-fixture artifact, not a real-world cost. Lockfiles live in `DEFAULT_IGNORED_FILES` and the `.lock` extension lives in `DEFAULT_IGNORED_EXTENSIONS` (see `src/lib/config/constants.ts`), so `getChanges` strips them before the diff-condensing pipeline ever sees them on a real `coco commit`. - Drop `yarn.lock` from DEP_BUMP_FILES; the realistic shape is just `package.json` + `CHANGELOG.md`. - Update the dep-bump-shape test to assert the post-filter invariant (no lockfiles in the fixture) instead of asserting a lockfile is present. - Add a guard test that fails loudly if any future fixture accidentally drifts back into including a default-ignored file. - Re-baseline. dep-bump now reports 0 ms / 0 LLM calls (early exit, total budget already under threshold), reflecting what a real dep bump costs the pipeline. The "lockfile fast-path" optimization angle from the original plan is dropped — the existing ignore filter already handles that, and any pipeline-level skip would be redundant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The user pointed out that lockfiles should already be auto-skipped — and they're right.
DEFAULT_IGNORED_FILES(src/lib/config/constants.ts:5-12) coverspackage-lock.json,yarn.lock,pnpm-lock.yaml,bun.lockb,bun.lock, plusnode_modules;DEFAULT_IGNORED_EXTENSIONScovers.lockand.map.getChangesstrips matching files before the diff-condensing pipeline ever sees them.The dep-bump fixture from #849 included
yarn.lockand reported 27 s / 1 LLM call / 20k prompt tokens for it. That was a bench-fixture artifact, not a real-world cost — and the original "lockfile fast-path" angle from the plan is moot because the existing filter already handles it.Fix
yarn.lockfromDEP_BUMP_FILES; the realistic post-filter shape is justpackage.json+CHANGELOG.md.DEFAULT_IGNORED_FILESor extension inDEFAULT_IGNORED_EXTENSIONS). Catches this class of mistake at CI time.Re-captured baseline
Other fixtures unchanged (re-ran for completeness; numbers within ms of prior baseline). The new full baseline is committed at
.bench/baseline.json.Plan implication
The original
#845plan listed a "lockfile fast-path" optimization angle. Dropped — the existing ignore filter already handles it; any pipeline-level skip would be redundant. The remaining optimization plan stands as-is.Test plan
npm run lintnpm run test:jest(1250 tests pass — added guard test + updated dep-bump shape assertion)npm run buildnpm run test:clinpm run bench --update→ dep-bump now reports 0ms / 0 calls