Convert All Default Implementations on Enums to derive(Default)#3083
Merged
cwfitzgerald merged 3 commits intogfx-rs:masterfrom Oct 7, 2022
Merged
Convert All Default Implementations on Enums to derive(Default)#3083cwfitzgerald merged 3 commits intogfx-rs:masterfrom
cwfitzgerald merged 3 commits intogfx-rs:masterfrom
Conversation
cwfitzgerald
approved these changes
Oct 7, 2022
Member
cwfitzgerald
left a comment
cwfitzgerald
left a comment
There was a problem hiding this comment.
Code looks good, just need to change the msrv in the Readme and ci to be the latest needed for #[default]
Contributor
Author
|
It seems that the minimum supported version is now |
Member
|
Nice, not nearly as bad as I thought |
Contributor
Author
|
Yes, it's not so bad and it seems to have passed the test now. Should we add an entry to the changelog to say that the msvr has changed ? If so, I don't really know how and what to add, any ideas ? |
Member
|
Look at last releases big announcements - I'd add a thing like that that just says what msrv we bumped to. |
Contributor
Author
|
Thank you ! I think it's pretty understandable as is, what do you think ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Closes #3077.
Description
Since rust-lang/rust#101040, we can now mark enums as
#[default], this replaces manual implementation where possible.Testing
I ran the cargo test before and after the changes and nothing changed, so I guess nothing was broken because these are very simple changes.