llama-quantize: fix tensor-type logic#21482
Closed
theo77186 wants to merge 2 commits into
Closed
Conversation
bf3d732 to
3f53ec2
Compare
Contributor
Author
|
superseded by #22572 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix quantization type selection with
--tensor-typewhen the requested type is the same as the base type.Additional information
For example, when quantizing to Q4_K_M, using
--tensor-type ffn_down=Q4_Kfails to get applied at all because in the current code, the conditionqtype != new_typewould evaluate to false, only to get overridden with thellama_tensor_get_type_implcall.Requirements