llama: refactor fused ops#24646
Merged
Merged
Conversation
This was referenced Jul 1, 2026
Merged
ggerganov
reviewed
Jul 8, 2026
ggerganov
left a comment
ggerganov
left a comment
Member
There was a problem hiding this comment.
The LLAMA_TENSOR_NAME_s from llama-impl.h are no longer needed - can be removed
ggerganov
reviewed
Jul 8, 2026
ggerganov
approved these changes
Jul 8, 2026
Contributor
Author
|
@ggml-org/maintainers can I get another approval? |
ServeurpersoCom
approved these changes
Jul 8, 2026
ngxson
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Refactor op detection to be more streamlined, add
llm_graph_fused_nodeso that we don't rely on tensor names. The intention is to make adding new attention ops (e.g. #24231 + various other new interesting ops in dsv4) easier.Additional information
Requirements