server : drop the need for vendor subprocess.h#25052
Open
mfuntowicz wants to merge 7 commits into
Open
Conversation
…s) and monitor status along with reading stdin/stdout
# Conflicts: # tools/server/server-models.cpp # tools/server/server-models.h
angt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the first of a potential serie to get rid of third-party dependency to manage subprocess lifecycle.
First to benefit is
llama-serverfor which the new, in-tree, implementation provides all the required knobs to replicate what was done through previous vendor dependency.Notes:
std::optionalencapsulating the subprocess as the statement of emptyness is not true anymore