Improve utilization (and tg t/s) by reducing K_QUANTS_PER_ITERATION to 1 on DMMV path#25063
Open
malsbat wants to merge 4 commits into
Open
Improve utilization (and tg t/s) by reducing K_QUANTS_PER_ITERATION to 1 on DMMV path#25063malsbat wants to merge 4 commits into
malsbat wants to merge 4 commits into
Conversation
The reordered feature is implemented in ggml_sycl_op_dequantize_mul_mat_vec, but gated by ggml_sycl_supports_reorder_dmmv. This commit fixes the gate. Signed-off-by: Todd Malsbary <todd.malsbary@intel.com>
When combined with opening the reorder gate, this improves GPU utilization on B70, giving a significant boost to tg t/s. Signed-off-by: Todd Malsbary <todd.malsbary@intel.com>
Signed-off-by: Todd Malsbary <todd.malsbary@intel.com>
Without this, the extra field is not allocated and the reorder path will not take effect. Signed-off-by: Todd Malsbary <todd.malsbary@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The DMMV path recently changed the warp size from 32 to 16. When combined with the reordered layout and reducing K_QUANTS_PER_ITERATION to 1 the work group size is increased from 16 to 32, resulting in reduced stalls and better utilization.
This gives a significant performance boost to tg t/s, up to 1.53x for Q4_K.
Additional information
Smoke tests on B70 comparing baseline (master branch @ 3fc4e10), KQPI=1 with the AOS layout, and finally with SOA layout.
More benchmarks with different models.
Requirements