hexagon: flash attention rework (optimizations, accuracy improvements, etc)#25085
Draft
max-krasnyansky wants to merge 44 commits into
Draft
hexagon: flash attention rework (optimizations, accuracy improvements, etc)#25085max-krasnyansky wants to merge 44 commits into
max-krasnyansky wants to merge 44 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The main focus here is to update
FLASH_ATTN_EXTinggml-hexagonsimilar to what I did in #24954htp/flash-atten-ops.cand removing duplicationhtp/{hvx,hmx}-fa-kernels.hSimilar to hexagon: store HMX flash-attention softmax accumulators in FP32 #24389
The PR also includes some
MUL_MATupdates as a followup to #24954.As I was looking at Flash Attention op-traces I noticed a few more things to improve in
MUL_MAT.Technically, I could split that up but I did extensive testing of the combined update.
Additional information
Tested on all supported devices.
Newer devices show higher gains but there are steady improvements across the board
Details
Requirements