Revert PR #20793#25120
Closed
nathanmp wants to merge 1 commit into
Closed
Conversation
github-actions
Bot
added
ggml
Contributor
|
Please let the author revert PRs. |
Author
|
I read the contribution guidelines and I didn't see anything that prohibits someone other than the author from reverting PRs, so I'm not sure how I should've known that was expected. My bad? |
Contributor
|
It's just common courtesy. We can't put everything in the contribution guidelines |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Reverts PR #20793 ("Sched: Reintroduce less synchronizations between token, with fixed pipeline parallelism."), which causes a major performance loss on AMD hardware. Johannes said it should be reverted, so here we are.
Requirements