Look up keys to wired-in pkg keys at runtime instead of generating a YAML#466
Closed
Ericson2314 wants to merge 1 commit intoghcjs:masterfrom
Closed
Look up keys to wired-in pkg keys at runtime instead of generating a YAML#466Ericson2314 wants to merge 1 commit intoghcjs:masterfrom
Ericson2314 wants to merge 1 commit intoghcjs:masterfrom
Conversation
Member
|
This would defeat the purpose of the current setup, where the exact version bundled in the ghcjs-boot libraries (or inside the ghcjs repo in case of ghcjs-th and ghcjs-prim) needs to be loaded. Let me know if you need help making things work on Nix, but unfortunately changing the lookup to runtime is not a good idea at the moment (at least until I'm sure that we can guarantee that the correct packages are loaded) |
Member
Author
|
The idea is Nix would guarantee that the proper version would be loaded. Maybe this can be a compile time option to be used by Nix but not normal builds? In any event, I consider converting patches to workspaces a higher priority for my build system work than this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this worked for me doing my Nix stuff, and it seems generally simpler.