Skip to content

Look up keys to wired-in pkg keys at runtime instead of generating a YAML#466

Closed
Ericson2314 wants to merge 1 commit intoghcjs:masterfrom
forked-upstream-packages-for-ghcjs:p4
Closed

Look up keys to wired-in pkg keys at runtime instead of generating a YAML#466
Ericson2314 wants to merge 1 commit intoghcjs:masterfrom
forked-upstream-packages-for-ghcjs:p4

Conversation

@Ericson2314
Copy link
Copy Markdown
Member

I think this worked for me doing my Nix stuff, and it seems generally simpler.

@luite
Copy link
Copy Markdown
Member

luite commented Jul 3, 2016

This would defeat the purpose of the current setup, where the exact version bundled in the ghcjs-boot libraries (or inside the ghcjs repo in case of ghcjs-th and ghcjs-prim) needs to be loaded.

Let me know if you need help making things work on Nix, but unfortunately changing the lookup to runtime is not a good idea at the moment (at least until I'm sure that we can guarantee that the correct packages are loaded)

@luite luite closed this Jul 3, 2016
@Ericson2314
Copy link
Copy Markdown
Member Author

The idea is Nix would guarantee that the proper version would be loaded. Maybe this can be a compile time option to be used by Nix but not normal builds?

In any event, I consider converting patches to workspaces a higher priority for my build system work than this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants