Skip to content

Fix $or in InMemDao (GSI-2508) - #248

Merged
TheByronHimes merged 4 commits into
mainfrom
feature/fix_in_mem_dao_GSI-2508
Aug 4, 2026
Merged

Fix $or in InMemDao (GSI-2508)#248
TheByronHimes merged 4 commits into
mainfrom
feature/fix_in_mem_dao_GSI-2508

Conversation

@TheByronHimes

Copy link
Copy Markdown
Member

$or conditions with multiple expressions are flattened incorrectly to a list of 'or' instead of 'and'.
So something like

{
    "$or": [
        <some single expression that is False in our case>,
        {"fieldX": 100, "fieldY": True}
    ]
}

would incorrectly also return documents where the first expression is false and only the fieldX or fieldY expressions are True (when it should require both to be true for the branch to be true).

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 29520100309

Coverage decreased (-0.03%) to 93.632%

Details

  • Coverage decreased (-0.03%) from the base build.
  • Patch coverage: 2 uncovered changes across 1 file (11 of 13 lines covered, 84.62%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
src/hexkit/providers/testing/dao.py 13 11 84.62%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 3989
Covered Lines: 3735
Line Coverage: 93.63%
Coverage Strength: 0.94 hits per line

💛 - Coveralls

@TheByronHimes
TheByronHimes requested a review from mephenor July 16, 2026 19:19
mephenor
mephenor previously approved these changes Jul 20, 2026
@TheByronHimes
TheByronHimes requested a review from mephenor August 4, 2026 08:42
@TheByronHimes
TheByronHimes merged commit a9e24d8 into main Aug 4, 2026
8 checks passed
@TheByronHimes
TheByronHimes deleted the feature/fix_in_mem_dao_GSI-2508 branch August 4, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants