Conversation
Co-authored-by: Jacky Volpes <34267385+Djedouas@users.noreply.github.com>
|
cc @nforquet |
|
thanks for the addition, really appreciated! Can you share the dataset so I can start the review with the same data you have used? |
ghtmtt
left a comment
ghtmtt
left a comment
There was a problem hiding this comment.
thanks for the this new plot type, really appreciated! As stated in the main comment, can you share the dataset used?
| self.x_combo: ['all'], | ||
| self.y_label: ['scatter', 'bar', 'box', 'pie', '2dhistogram', 'polar', 'ternary', 'contour', 'violin'], | ||
| self.y_combo: ['scatter', 'bar', 'box', 'pie', '2dhistogram', 'polar', 'ternary', 'contour', 'violin'], | ||
| self.feature_subset_defined_button: ['scatter', 'bar', 'box', 'pie', '2dhistogram','histogram', 'polar','ternary', 'contour', 'violin'], |
There was a problem hiding this comment.
is there any specific reason to not include also radar plot with the feature subset? If yes, also the label_feature_subset label should be removed
There was a problem hiding this comment.
Good catch!
There is no reason not to use the feature_subset_defined option with radar plot, on the contrary :)
| from qgis.PyQt.QtGui import QIcon | ||
| from DataPlotly.core.plot_types.plot_type import PlotType | ||
| import plotly.colors as pc | ||
|
|
There was a problem hiding this comment.
missing QCoreApplication import:
from qgis.PyQt.QtCore import QCoreApplication
|
hi @ghtmtt , here are the test data used in the screenshots: data_test.csv |
thanks! seems fantastic! Even if the documentation repository needs a total refactor, do you mind to add also the documentation following the other plot templates? https://github.com/ghtmtt/DataPlotly-docs |
line type and combo box are now decorrelated
|
I added a few commits because I found a bug with the threshold line, when writing the documentation (classic!). |
Refresh the UI according to Points, Line, Points and Lines marker type not only when marker type changes, but also when the plot type changes (to be correctly initialized).
|
Documentation PR is here ghtmtt/DataPlotly-docs#5 |
|
thanks for you contribution! |
3 participants
This pull request adds a new plot type: radar plots.
The logic of the radar plot is a little bit different from other plot types: an entire trace is added for each feature.
New widgets have been added:
The widgets have been added to the read/write settings features.
Funded by INRAE - Reversaal