Skip to content

improve compatibility#17

Open
johnd0e wants to merge 1 commit intoghybs:masterfrom
johnd0e:improve-compatibility
Open

improve compatibility#17
johnd0e wants to merge 1 commit intoghybs:masterfrom
johnd0e:improve-compatibility

Conversation

@johnd0e
Copy link
Copy Markdown

@johnd0e johnd0e commented Jun 6, 2019

with layers that have:

  • custom getTileUrl method
  • options required zoom preprocessing (_getZoomForUrl)
    • zoomOffset/zoomReverse/enableRetina
    • maxNativeZoom different from maxZoom
    • minNativeZoom different from minZoom
(Well, not all ot these may be in case, need to be checked)

This change is Reviewable

with layers that have:
- custom getTileUrl method
- options required zoom preprocessing (_getZoomForUrl)
  - zoomOffset/zoomReverse/enableRetina
  - maxNativeZoom different from maxZoom
  - minNativeZoom different from minZoom
@johnd0e
Copy link
Copy Markdown
Author

johnd0e commented Jun 6, 2019

It is sample draft of PR, to illustrate #15.
Completely untested, sorry, as I do not use this plugin.
Feel free to merge/modify/close.

P.S.
To make things more elegant it'd be better to enhance _getZoomForUrl in Leaflet itself.
It could take zoom level as argument, instead of pulling it ftom this._tileZoom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant