Skip to content

Fix for generic interfaces #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pil0t wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for generic interfaces #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions DocsByReflection.UnitTests.Stubs/GenericInterface.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
namespace DocsByReflection.UnitTests.Stubs
{
/// <summary>
/// Summary of GenericInterface
/// </summary>
/// <typeparam name="T"></typeparam>
public interface GenericInterface<T>
{
}
}
9 changes: 8 additions & 1 deletion DocsByReflection.UnitTests/DocsServiceTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,19 @@ public void GetXmlFromType_Class_XmlElement()
var actual = DocsService.GetXmlFromType(typeof(Stub));
Assert.AreEqual("Stub class.", actual.SelectSingleNode("summary").InnerText.Trim());
}

[Test]
public void GetXmlFromAssembly_Assembly_XmlElement()
{
var actual = DocsService.GetXmlFromAssembly(typeof(Stub).Assembly);
StringAssert.EndsWith("DocsByReflection.UnitTests.Stubs", actual.SelectSingleNode("//name").InnerText);
}

[Test]
public void GetXmlFromType_GenericInterface_XmlElement()
{
var actual = DocsService.GetXmlFromType(typeof(GenericInterface<>));
Assert.AreEqual("Summary of GenericInterface", actual.SelectSingleNode("summary").InnerText.Trim());
}
}
}
2 changes: 1 addition & 1 deletion DocsByReflection/DocsTypeService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public static string GetTypeFullNameForXmlDoc(Type type, bool isOut = false, boo
Type[] args = type.GetGenericArguments();
string fullTypeName = string.Empty;
string typeNamespace = type.Namespace == null ? "" : string.Format("{0}.", type.Namespace);
if (type.MemberType == MemberTypes.TypeInfo && (type.IsGenericType || args.Length > 0) && (!type.IsClass || isMethodParameter))
if (type.MemberType == MemberTypes.TypeInfo && (type.IsGenericType || args.Length > 0) && (!(type.IsClass || type.IsInterface) || isMethodParameter))
{
//2016-10-06 by Jeffrey, support multiple generic arguments
return String.Format(CultureInfo.InvariantCulture,
Expand Down