Skip to content

Fix null safety bug #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KARIM2M wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix null safety bug #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ffe0b4b
Update ArCoreViewFactory.kt
KARIM2M Oct 4, 2022
77ad888
Update ArcoreFlutterPlugin.kt
KARIM2M Oct 4, 2022
024d5b8
Update ArCoreViewFactory.kt
KARIM2M Oct 4, 2022
6a92eaa
Update ArCoreViewFactory.kt
KARIM2M Oct 4, 2022
d81051c
Update ArCoreViewFactory.kt
KARIM2M Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions android/src/main/kotlin/com/difrancescogianmarco/arcore_flutter_plugin/ArCoreViewFactory.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import io.flutter.plugin.platform.PlatformViewFactory

class ArCoreViewFactory(val activity: Activity, val messenger: BinaryMessenger) : PlatformViewFactory(StandardMessageCodec.INSTANCE) {

override fun create(context: Context, id: Int, args: Any?): PlatformView {
override fun create(context: Context?, id: Int, args: Any?): PlatformView {
val params = args as HashMap<*, *>
val debug = params["debug"] as Boolean
val type = params["type"] as String
Expand All @@ -22,11 +22,11 @@ class ArCoreViewFactory(val activity: Activity, val messenger: BinaryMessenger)
}

if (type == "faces") {
return ArCoreFaceView(activity, context, messenger, id, debug)
return ArCoreFaceView(activity, context!!, messenger, id, debug)
} else if (type == "augmented") {
val useSingleImage = params["useSingleImage"] as? Boolean ?: true
return ArCoreAugmentedImagesView(activity, context, messenger, id, useSingleImage, debug)
return ArCoreAugmentedImagesView(activity, context!!, messenger, id, useSingleImage, debug)
}
return ArCoreView(activity, context, messenger, id, type == "faces", debug)
return ArCoreView(activity, context!!, messenger, id, type == "faces", debug)
}
}
}
4 changes: 2 additions & 2 deletions ...oid/src/main/kotlin/com/difrancescogianmarco/arcore_flutter_plugin/ArcoreFlutterPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class ArcoreFlutterPlugin : FlutterPlugin, ActivityAware {
fun registerWith(registrar: Registrar) {
registrar
.platformViewRegistry()
.registerViewFactory(CHANNEL_NAME, ArCoreViewFactory(registrar.activity(), registrar.messenger()))
.registerViewFactory(CHANNEL_NAME, ArCoreViewFactory(registrar.activity()!!, registrar.messenger()))
}
}

Expand Down Expand Up @@ -64,4 +64,4 @@ class ArcoreFlutterPlugin : FlutterPlugin, ActivityAware {
}


}
}