Skip to content

Added new parameter to enable/disable the white dots on surface #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giandifra merged 1 commit into from
Oct 20, 2020
Merged

Added new parameter to enable/disable the white dots on surface #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion android/src/main/kotlin/com/difrancescogianmarco/arcore_flutter_plugin/ArCoreView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,13 @@ class ArCoreView(val activity: Activity, context: Context, messenger: BinaryMess
// detected.
arSceneView?.scene?.addOnUpdateListener(sceneUpdateListener)
}

val enablePlaneRenderer: Boolean? = call.argument("enablePlaneRenderer")
if (enablePlaneRenderer != null && !enablePlaneRenderer) {
Log.i(TAG, " The plane renderer (enablePlaneRenderer) is set to " + enablePlaneRenderer.toString())
arSceneView!!.planeRenderer.isVisible = false
}

result.success(null)
}

Expand Down Expand Up @@ -482,7 +489,7 @@ class ArCoreView(val activity: Activity, context: Context, messenger: BinaryMess
}

if (arSceneView?.session != null) {
// arSceneView!!.planeRenderer.isVisible = false
//arSceneView!!.planeRenderer.isVisible = false
Log.i(TAG, "Searching for surfaces")
}
}
Expand Down
3 changes: 3 additions & 0 deletions lib/src/arcore_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ class ArCoreController {
ArCoreController({
int id,
this.enableTapRecognizer,
this.enablePlaneRenderer,
this.enableUpdateListener,
// @required this.onUnsupported,
}) {
Expand All @@ -45,6 +46,7 @@ class ArCoreController {

final bool enableUpdateListener;
final bool enableTapRecognizer;
final bool enablePlaneRenderer;
MethodChannel _channel;
StringResultHandler onError;
StringResultHandler onNodeTap;
Expand All @@ -59,6 +61,7 @@ class ArCoreController {
try {
await _channel.invokeMethod<void>('init', {
'enableTapRecognizer': enableTapRecognizer,
'enablePlaneRenderer': enablePlaneRenderer,
'enableUpdateListener': enableUpdateListener,
});
} on PlatformException catch (ex) {
Expand Down
11 changes: 7 additions & 4 deletions lib/src/arcore_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ class ArCoreView extends StatefulWidget {
// final UnsupportedHandler onArCoreUnsupported;

final bool enableTapRecognizer;
final bool enablePlaneRenderer;
final bool enableUpdateListener;
final ArCoreViewType type;

Expand All @@ -21,6 +22,7 @@ class ArCoreView extends StatefulWidget {
@required this.onArCoreViewCreated,
// @required this.onArCoreUnsupported,
this.enableTapRecognizer = false,
this.enablePlaneRenderer = true,
this.enableUpdateListener = false,
this.type = ArCoreViewType.STANDARDVIEW,
}) : super(key: key);
Expand Down Expand Up @@ -58,11 +60,12 @@ class _ArCoreViewState extends State<ArCoreView> with WidgetsBindingObserver {
return;
}
widget.onArCoreViewCreated(ArCoreController(
id: id,
enableTapRecognizer: widget.enableTapRecognizer,
enableUpdateListener: widget.enableUpdateListener,
id: id,
enableTapRecognizer: widget.enableTapRecognizer,
enableUpdateListener: widget.enableUpdateListener,
enablePlaneRenderer: widget.enablePlaneRenderer
// onUnsupported: widget.onArCoreUnsupported,
));
));
}

@override
Expand Down