feat(run-tests-with-ats): run app-test-suite container directly, drop dats.sh - #839
Open
QuentinBisson wants to merge 4 commits into
Open
feat(run-tests-with-ats): run app-test-suite container directly, drop dats.sh#839QuentinBisson wants to merge 4 commits into
QuentinBisson wants to merge 4 commits into
Conversation
… dats.sh app-test-suite removed the dats.sh wrapper. Run the container image directly with docker run instead of downloading and executing dats.sh. Removes the app-test-suite_version parameter (it only selected the dats.sh ref). BREAKING CHANGE: requires a new major version.
QuentinBisson
marked this pull request as ready for review
July 6, 2026 11:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
run-tests-with-atsno longer downloads and runs thedats.shwrapper from theapp-test-suiterepo. It runs theapp-test-suitecontainer image directly withdocker run.Why
app-test-suitehas removeddats.sh(giantswarm/app-test-suite#642). The command currently doeswget https://raw.githubusercontent.com/giantswarm/app-test-suite/<version>/dats.sh, which now 404s for any consumer pinning to a current ref.dats.shwas only a thindocker runwrapper, so the orb can invoke the container itself.Changes
src/commands/run-tests-with-ats.yaml: replace theDownload dats.sh+./dats.shsteps with a directdocker run gsoci.azurecr.io/giantswarm/app-test-suite:<tag> --chart-file ... <flags>(same uid/gid, docker.sock, and--network hostthe wrapper used;-itdropped for CI).app-test-suite_container_tagtoapp-test-suite_version(it now selects the container image tag; previouslyapp-test-suite_versionselected thedats.shgit ref). Default1.0.0.docs/job/run-tests-with-ats.md.Migration (BREAKING, requires major → v10.0.0)
app-test-suite_container_tag:must rename it toapp-test-suite_version:.app-test-suite_version:to adats.shgit ref must change the value to a container image tag (e.g.1.0.0).giantswarm/architect@9keeps the olddats.shpath; bump to@10for direct container execution.Cut the release via the
main#release#majortrigger. CircleCI orb pack/validate runs in CI (no localcircleciCLI).