fix(deps): prune stale yarn.lock entries - #2048
Open
marians wants to merge 1 commit into
Open
Conversation
`yarn install --immutable` fails on main with YN0028 ("the lockfile would have
been modified by this install"), so node-build is red on main and on every PR
branched from it.
The grafana bump in #2046 changed which transitive @backstage/* versions are
needed, but the committed lockfile kept the entries the previous resolution had
required. A clean resolution prunes seven now-unreferenced descriptors, which is
exactly what --immutable refuses to do silently.
This commit is that prune and nothing else: 173 deletions, no insertions, no
resolved version changed. Verified `yarn install --immutable` completes through
resolution, fetch and link.
1 task
JS Dependency Audit0 added · 0 removed · 206 total (0 vs base) Projects audited
No change in vulnerabilities compared to the base branch. Full current vulnerability list (206)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Unblocks CI.
yarn install --immutablecurrently fails onmain:node-buildis therefore red onmain(pipeline 9562) and on every PR branched from it.The grafana bump in #2046 changed which transitive
@backstage/*versions are needed, but the committed lockfile kept the descriptors the previous resolution had required. A clean resolution prunes seven now-unreferenced entries — which is precisely what--immutablerefuses to do silently. CI's own log names them in itsYN0085line.Pruned:
@backstage/catalog-client@npm:^1.16.0@backstage/core-compat-api@npm:^0.5.12@backstage/integration-react@npm:^1.2.19@backstage/plugin-app-react@npm:^0.2.4@backstage/plugin-catalog-react@npm:^3.1.0@backstage/plugin-permission-react@npm:^0.5.2@backstage/ui@npm:^0.16.0173 deletions, no insertions, no resolved version changed — so nothing about the installed tree changes; the lockfile just stops carrying entries nothing references.
What is the effect of this change to users?
None. No dependency version changes.
Any background context you can provide?
Found while opening #2047 (base-image digest pin), whose
node-buildfailed identically despite touching only a Dockerfile — which is what pointed atmainrather than at that branch.Verified locally:
yarn install --immutablecompletes through resolution, fetch and link with noYN0028.Worth considering separately: Renovate produced a lockfile that
--immutablerejects, so it can presumably do so again. If this recurs, apostUpgradeTaskslockfile refresh (or a dedupe step) would stop it reachingmain.Do the docs need to be updated?
No.
Should this change be mentioned in the release notes?
Not applicable — lockfile-only change, no published package affected.