Skip to content

fix: create action ignores size/replicas inputs#64

Merged
gigatim merged 2 commits intomainfrom
fix-create-action-ignores-size
Mar 30, 2026
Merged

fix: create action ignores size/replicas inputs#64
gigatim merged 2 commits intomainfrom
fix-create-action-ignores-size

Conversation

@gigatim
Copy link
Copy Markdown
Collaborator

@gigatim gigatim commented Mar 30, 2026

Summary

  • The handleCreate function (used by action: create and action: create_deploy) never read the size or replicas inputs, so they were silently ignored
  • After app creation, now calls handleScale when either size or replicas is provided
  • Updated action.yml input descriptions to reflect that size and replicas work with create actions
  • Fixed a pre-existing type error in the test suite's mockExecWithRevParse helper
  • Added tests for create-with-size and create-without-size scenarios

Test plan

  • Existing tests pass (make test — 38 tests)
  • New test verifies scale API is called after create when size is provided
  • New test verifies scale API is NOT called after create when size is omitted
  • Manual: test action: create with size: 0.5 in a workflow

gigatim added 2 commits March 30, 2026 15:47
The handleCreate function used by `action: create` and
`action: create_deploy` never read the `size` or `replicas`
inputs, so they were silently ignored. Now calls handleScale
after app creation when either input is provided.

Also fixes a pre-existing type error in the test suite's
mockExecWithRevParse helper.
@gigatim gigatim merged commit 4f94d5f into main Mar 30, 2026
1 check passed
@gigatim gigatim deleted the fix-create-action-ignores-size branch March 30, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant