fix: create action ignores size/replicas inputs#64
Merged
Conversation
The handleCreate function used by `action: create` and `action: create_deploy` never read the `size` or `replicas` inputs, so they were silently ignored. Now calls handleScale after app creation when either input is provided. Also fixes a pre-existing type error in the test suite's mockExecWithRevParse helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handleCreatefunction (used byaction: createandaction: create_deploy) never read thesizeorreplicasinputs, so they were silently ignoredhandleScalewhen eithersizeorreplicasis providedaction.ymlinput descriptions to reflect thatsizeandreplicaswork with create actionsmockExecWithRevParsehelperTest plan
make test— 38 tests)sizeis providedsizeis omittedaction: createwithsize: 0.5in a workflow