Symbolification improvements#2
Open
yoavst wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix vtable function name conflict using a numeric suffix
I think it is better than the current implementation. No ideal, but as long as there is no support for it in IDA its the best I can think of.
Fix PAC Symbolicate algorithm.
The signature on the func
C::fis:fwas added inC, thenhash(C::f)Bparent ofC, so the hash ishash(B::f).Therefore, the algorithm should be simply:
vmethod_xxwas added, search for the signature only in the same classAs a TODO, we need to generate names for pure virtual methods (which use the parent symbol to call, but the symbol is not available on binary). Also, we could use iOS 16.5 symbols as well to enrich. Finally, we need to support
OSMetaClassBasemethods that we ignore and say they are ofOSObject.Another TODO is figure why it still doesn't work for some methods, like
__ZNK15IORegistryEntry11setPropertyEPKcS1_(method indexed 26 of IORegistryEntry). It is the same name as 16.4 so I wonder what could be the reason.