Add macOS support; Add Windows support; And more... by rjaros87 · Pull Request #33 · gildegoma/chef-android-sdk

rjaros87 · 2016-07-24T11:05:51Z

Major changes:

Added Windows support
Added ServerSpec test Test Kitchen Clean Up #5
Added chefignore file Add .chefignore #30

Minor changes:

Unsupport Centos OS < 7 due to Android SDK use GNU C Library (glibc) 2.14 or later
Cleanup default['android-sdk']['components']

rjaros87 · 2016-07-24T11:20:32Z

@gildegoma please review. Pull request #32 is necessary for this PR

Brantone · 2017-01-25T07:25:07Z

+  prefix_root node['android-sdk']['setup_root']
+  prefix_home node['android-sdk']['setup_root']
+  owner node['android-sdk']['owner']
+  group node['android-sdk']['group'] unless mac_os_x?


Don't think this should be forced to be unless mac_os_x . Takes control away from downstream cookbooks.

Brantone · 2017-01-25T07:46:20Z

+      environment 'ANDROID_HOME' => android_home
+      path [File.join(android_home, 'tools')]
+      user node['android-sdk']['owner']
+      group node['android-sdk']['group'] unless mac_os_x?


I suspect this is strictly because chef-client might be run as root with wheel group, which is the tmp script owner?

as previous PR i will remove limitation for mac_os_x

Ah, k, wasn't sure if I had messed up. If I even set user/group to anything other than root / wheel I always get error:

STDERR: couldn't read file "/var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/chef-script20170125-55984-udq962": permission denied

Still tracking down why that might be :(

use http://www.rubydoc.info/github/opscode/chef/Chef/Mixin/HomebrewUser#find_homebrew_uid-instance_method :) this should solves your problem with user.

gildegoma · 2017-01-25T09:39:31Z

@rjaros87 @Brantone Sorry guys for being so unresponsive... This PR contains a lot of different things, making the review more difficult and time consuming (and I lack of large bunch of spare time).

I'll do my best to reserve some time for starting soon though. Do you have by the way some good Packer templates to build local VMs for testing on Windows and Mac (Virtualbox, Parallels or VMware welcome, or recommendation for a good Cloud provider, ideally well supported by Vagrant plugin ecosystem)? ❤️ ❤️ ❤️

Brantone · 2017-01-25T10:42:10Z

+    only_if { node['android-sdk']['set_environment_variables'] }
+  end
+elsif mac_os_x?
+  bash_profile 'profile.android_sdk' do


Getting mixed results with ~/.bash_profile when sudo su to android-sdk user.
Not sure if Sierra is hitting the order of sourcing bash files differently.

Just test it :) using Vagrant & Virtualbox & .kitchen

Yup, that's what I was doing. In simple kitchen test it's fine, it's when it's integrated with an environment cookbook. More specifically, when logging in as one user, then sudoing to another. I actually think the export PATH online 116 could probably go in /etc/paths.d/android-sdk then it's system wide, not just to specific user.

rjaros87 · 2017-01-25T16:05:54Z

@gildegoma I use Vagrant + VirtualBox (with extension pack) and Kitchen :) as you know everything is in .kitchen.yml

For testing Windows you need also Vagrant plugin for WinRM vagrant plugin install vagrant-winrm

gildegoma · 2017-01-25T16:26:31Z

@rjaros87 Sorry, I missed the fact that your last commit (04dd45b) added two new kitchen boxes (mac_el_capitan and windows-2012R2). I'll test all this together, but as already said, I appreciate if in the future you can please create PR focused on a single specific addition.
Looking forward though, thanks again for all the work and your patience 💟

rjaros87 · 2017-01-25T17:50:49Z

@gildegoma
#29 - 7 file to review
#32 15 files - 7 files = 8 files to review
this #33 20 files - 15files = 5 files to review

Remove macOS group constraint and bump some dep versions

rjaros87 · 2017-02-02T09:39:42Z

@gildegoma ready to review. Please close other pull request and make review this one.

gildegoma · 2017-02-02T09:58:44Z

Thank you @rjaros87 for all these propositions. As mentionned, having all these different things packed together is not the ideal way to get things merged quickly. I really value your efforts and work, and will do my best to do this review "asap", and hopefully take in most (if not all) your changes.

Here is a short and recent article about the "hard work" to maintain stable projects: https://www.jeffgeerling.com/blog/2016/why-i-close-prs-oss-project-maintainer-notes

But as already said above, I'm glad you made all this work and I am looking forward to integrate it here ❤️ ❤️ ❤️

…ndows_fix_sdk25

Fix for sdk25

rjaros87 · 2017-03-04T13:59:55Z

@gildegoma did you disable travis tests?
After merge with above branch, nothing triggered.

gildegoma · 2017-03-04T15:25:58Z

@rjaros87 Yup, I temporarily disabled Travis CI (see #37) to avoid generating broken builds while preparing 0.2.1 release. This is active again. Please rebase onto an updated master and repush. The build should start again...

…into windows

rjaros87 · 2017-03-05T10:01:38Z

Please review my last changes.
@gildegoma maybe you should create a 0.2 branch from master and merge this PR. What do you think?
Because it's hard to maintain and resolve conflicts. In some commits you done the same as I couple months ago.

joshrlesch · 2017-08-15T15:08:27Z

Whats the status on this? Would be nice to use it from the supermarket.

Brantone · 2017-10-18T21:49:28Z

Adding my voice (again) to the "status?" pile.

Brantone · 2018-05-10T22:28:08Z

@gildegoma Been a long while since this has been open ... what can be done to move it along?

Brantone · 2018-07-28T07:12:53Z

Anyone?

rjaros87 · 2018-07-30T05:31:23Z

Only @gildegoma could merge this, no one have a permissions.
Let say, I'm no more involved with Chef, so this is my last commit ;)

Brantone · 2019-04-18T22:54:54Z

@gildegoma ?

rjaros87 and others added 6 commits June 23, 2016 09:42

Prevent backups of the android-sdk archive

5e64942

Added to metadata.rb attributes: issues_url, source_url

8c970fe

Use the latest Chef version for tests

b3ad4a1

Support Mac OS X

03394fd

Test chef-client in zero mode using Travis

1848d5e

Windows support

04dd45b

Bump cookbook version, depedency versions, and repoint Ark

e7dddbd

Brantone reviewed Jan 25, 2017

View reviewed changes

Remove mac_os_x group restrictions

e4b66c5

rjaros87 mentioned this pull request Jan 25, 2017

Remove macOS group constraint and bump some dep versions rjaros87/chef-android-sdk#1

Merged

Brantone and others added 3 commits January 26, 2017 02:53

Cleanup Rubocop, set group based on platform.

e284853

Update dna.json

d0e378c

Merge pull request #1 from Brantone/0.3.0-refactor

f42e9a9

Remove macOS group constraint and bump some dep versions

This was referenced Feb 2, 2017

Prevent backups of the android-sdk archive #29

Closed

Perform the true Chef run in Travis CI (linux and mac environments) #32

Closed

gildegoma changed the title ~~Add Windows support~~ Add macOS support; Add Windows support; And more... Feb 2, 2017

rjaros87 added 2 commits March 1, 2017 13:57

Add support for SDK 25

5ddec19

comment out 'wip suite'

47d08e1

gildegoma mentioned this pull request Mar 2, 2017

Fix for sdk25 rjaros87/chef-android-sdk#2

Merged

rjaros87 mentioned this pull request Mar 2, 2017

Fix for broken SDK 25 #35

Closed

gildegoma mentioned this pull request Mar 3, 2017

Enable Travis CI again #37

Open

rjaros87 and others added 3 commits March 3, 2017 20:36

Merge branch 'master' of github.com:rjaros87/chef-android-sdk into wi…

a27931a

…ndows_fix_sdk25

Update test and refactor Unix recipe

e877e10

Merge pull request #2 from rjaros87/windows_fix_sdk25

4c8d865

Fix for sdk25

gildegoma added the enhancement label Mar 4, 2017

gildegoma added this to the 0.3.0 milestone Mar 4, 2017

rjaros87 added 2 commits March 5, 2017 09:31

remove chef-sugar dependency and refactor

8a83b41

Merge branch 'master' of https://github.com/gildegoma/chef-android-sdk …

8303726

…into windows

rjaros87 mentioned this pull request Mar 5, 2017

Switch from Tailor to Rubocop? #7

Open

rjaros87 and others added 2 commits May 29, 2017 08:27

Merge branch 'master' into windows

7555d0f

Remove path attribute from script resource

0a807eb

rjaros87 force-pushed the windows branch 2 times, most recently from 8703ef2 to c602f96 Compare May 29, 2017 08:34

Increase ruby version for Travis and update Gemfile

481321f

rjaros87 force-pushed the windows branch from c602f96 to 481321f Compare May 29, 2017 08:45

Update cookbook style with new Rubocop & Foodcritic

5e89668

rjaros87 force-pushed the windows branch from c3f476b to 5e89668 Compare May 29, 2017 09:48

Conversation

rjaros87 commented Jul 24, 2016

Uh oh!

rjaros87 commented Jul 24, 2016

Uh oh!

Brantone Jan 25, 2017

Choose a reason for hiding this comment

Uh oh!

Brantone Jan 25, 2017

Choose a reason for hiding this comment

Uh oh!

rjaros87 Jan 25, 2017

Choose a reason for hiding this comment

Uh oh!

Brantone Jan 25, 2017

Choose a reason for hiding this comment

Uh oh!

rjaros87 Jan 25, 2017

Choose a reason for hiding this comment

Uh oh!

gildegoma commented Jan 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Brantone Jan 25, 2017

Choose a reason for hiding this comment

Uh oh!

rjaros87 Jan 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Brantone Jan 25, 2017

Choose a reason for hiding this comment

Uh oh!

rjaros87 commented Jan 25, 2017

Uh oh!

gildegoma commented Jan 25, 2017

Uh oh!

rjaros87 commented Jan 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rjaros87 commented Feb 2, 2017

Uh oh!

gildegoma commented Feb 2, 2017

Uh oh!

rjaros87 commented Mar 4, 2017

Uh oh!

gildegoma commented Mar 4, 2017

Uh oh!

rjaros87 commented Mar 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joshrlesch commented Aug 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Brantone commented Oct 18, 2017

Uh oh!

Brantone commented May 10, 2018

Uh oh!

Brantone commented Jul 28, 2018

Uh oh!

rjaros87 commented Jul 30, 2018

Uh oh!

Brantone commented Apr 18, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gildegoma commented Jan 25, 2017 •

edited

Loading

rjaros87 Jan 25, 2017 •

edited

Loading

rjaros87 commented Jan 25, 2017 •

edited

Loading

rjaros87 commented Mar 5, 2017 •

edited

Loading

joshrlesch commented Aug 15, 2017 •

edited

Loading