Skip to content

Add Group Verfications#4

Merged
gillg merged 2 commits into
gillg:masterfrom
nitrag:master
Feb 3, 2018
Merged

Add Group Verfications#4
gillg merged 2 commits into
gillg:masterfrom
nitrag:master

Conversation

@nitrag

@nitrag nitrag commented Jan 28, 2018

Copy link
Copy Markdown
Contributor

Thanks for writing this plugin!

I've made enhancements so that we can also verify that the user is in a specific group: "3DPrinters" for an extra level of access control.

@gillg

gillg commented Jan 28, 2018

Copy link
Copy Markdown
Owner

Many thanks for your enhancement ! It's a very good thing, and your code is OK for me.
I let your PR in stand by, because I work on a paralelle branch (see #3) to make this plugin more "standard" and add working config template.
I will see to merge now and rebase other branch or add your code after.

@gillg gillg left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is OK for me ;)

@gillg
gillg merged commit d750a79 into gillg:master Feb 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants