Skip to content

Enables the pure-ftpwho tool ...#3

Open
mhubig wants to merge 5 commits into
gimoh:masterfrom
mhubig:master
Open

Enables the pure-ftpwho tool ...#3
mhubig wants to merge 5 commits into
gimoh:masterfrom
mhubig:master

Conversation

@mhubig
Copy link
Copy Markdown

@mhubig mhubig commented Sep 9, 2016

In order to get the pure-ftpwho command working I needed to recompile pure-ftpd with the --with-ftpwho option ...

@gimoh
Copy link
Copy Markdown
Owner

gimoh commented Sep 12, 2016

Hi, thanks for the PR!
Two questions:

  • is the FEAT command necessary for pure-ftpwho to work?
  • what's the reason for changing the password database and config filenames?

@mhubig
Copy link
Copy Markdown
Author

mhubig commented Sep 12, 2016

is the FEAT command necessary for pure-ftpwho to work?

Nop, it's just good behavior ...

what's the reason for changing the password database and config filenames?

I set the pathnames to the default ones, this way I don't need to supply the pathnames to e.g. pure-pw ...

@gimoh
Copy link
Copy Markdown
Owner

gimoh commented Sep 14, 2016

Um, you shouldn't need to supply paths to pure-pw, etc. as it checks the env variables (PURE_DBFILE and PURE_PASSWDFILE), see README.VirtualUsers at the bottom in ENVIRONNEMENT VARIABLES section.

This was the reason for defining them and making sure they are loaded whatever way a shell session might be started.

As for pure-ftpwho and not using minimal, I'll see if we can maybe have two packages upstream in alpine, one minimal and one full blown. For our use case minimal was actually preferred.

@mhubig
Copy link
Copy Markdown
Author

mhubig commented Sep 14, 2016

Um, you shouldn't need to supply paths to pure-pw, etc. as it checks the env variables (PURE_DBFILE and PURE_PASSWDFILE) ... This was the reason for defining them and making sure they are loaded whatever way a shell session might be started.

Hmm, I see but they are not set if I use exec to connect to the container. Maybe it's better to set them within the Dockerfile ...

~ ❯❯❯ docker run -d -p 21:21 -p 50000-50020:50000-50020 --name ftpd -e PURE_USERS=isolated+noanon -e PURE_VIRT_USER_HOME_PATTERN=/srv/ftp/@USER@/./@USER@ gimoh/pureftpd -p 50000:50020 -P 127.0.0.1 -j -c 50 -C 5
d48865511eb2bd6ec5eb5f94eca62b2948fcca87fea12f6b6cee60e3e7545368
~ ❯❯❯ docker exec -it ftpd sh
/ # env
no_proxy=*.local, 169.254/16
HOSTNAME=d48865511eb2
SHLVL=1
HOME=/root
PUREFTPD_VERSION=1.0.42-r0
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
PURE_CONFDIR=/etc/pureftpd
PURE_USERS=isolated+noanon
PURE_VIRT_USER_HOME_PATTERN=/srv/ftp/@USER@/./@USER@
SYSLOG_STDOUT_VERSION=1.1.1
PWD=/

@gimoh
Copy link
Copy Markdown
Owner

gimoh commented Oct 2, 2017

gimoh added a commit that referenced this pull request Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants