Harden shell scripts against injection and failure modes#1026
Merged
Harden shell scripts against injection and failure modes#1026
Conversation
Collaborator
Author
This was referenced Apr 9, 2026
- Use mktemp for temp files instead of predictable PID-based names - Pass file paths via sys.argv instead of shell interpolation in Python - Add set -euo pipefail to scripts missing strict error handling - Fix pipe-to-while subshell variable scoping with here-strings - Add cleanup traps for temp files Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
jwiegley
force-pushed
the
johnw/review-harden-scripts
branch
from
d7b7e74 to
0d61f73
Compare
Use ${TEST_ARGS[@]+"${TEST_ARGS[@]}"} pattern to avoid "unbound
variable" error when TEST_ARGS is empty under set -u on macOS's
default bash 3.2, which doesn't handle empty array expansion.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com