Prep track builder#11
Merged
Merged
Conversation
This makes it much easier to use the API, in particular when Builder is a long-running operation
TrackMay may need a mutex in some context, but it doesn't in legacy setup (GitGraph) and it doesn't always in new usage (gitui). Gleisbau does not create a thread by itself. Therefore it should be the library user that adds a mutex.
Gleisbau should be able to work with any repository library, in particular both git2 and gix. To reduce the dependency some central structs are abstracted. In this case Commit Id. This opens for a more memory efficient implementation that uses an index instead of the real id.
Normal usize index is 8 bytes. Using u32 we save 4 bytes times the number of index stored. This macro makes it easy to define a new index type
Save 1 byte for each commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code cleanup in preparation for track::Builder which will be used for incremental construction of TrackMap.