Open
Conversation
Adds a new crates/kiln-benchmarks workspace member implementing the full benchmark suite described in docs/design/git-kiln-benchmarks.md. Benchmarks: 1. Action hash cache lookup (hit/miss at N=100, 1k, 10k refs) 2. Output tree ingestion (compression level 0 vs 6, repo size at 100/500 crates) 3. Output tree materialization (N=10, 50, 200 crates, odb vs fs timing) 4. Deduplication across crate versions (object count, dedup ratio) 5. Ref namespace scale (enumerate at 1k/10k/100k, lookup hit/miss) 6. Fetch simulation (transfer size estimates, local ingestion timing) 7. GC and pack behavior (size before/after, retained refs, delta compression) All repos are bare, remotes-free, created in tempfile::TempDir. core.looseCompression=0 is set on repos that store binary artifact blobs. Also: - Adds crates/kiln-benchmarks/README.md (results template + analysis guide) - Adds kiln-benchmarks to release-please config (publish=false) - Updates CD.yml: publishes only git-kiln, adds a benchmarks job that runs cargo bench and uploads results to GitHub Actions artifacts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the full benchmark suite described in
docs/design/git-kiln-benchmarks.md.What's included
New crate:
crates/kiln-benchmarksA
publish = falseworkspace member containing 7 Criterion benchmarks that measure Git's object store performance under Kiln's build cache access patterns. All repos are bare, created intempfile::TempDir, with no remotes configured.bench1_cache_lookupbench2_ingestionbench3_materializationbench4_deduplicationbench5_ref_namespacebench6_fetch_simulationbench7_gcgit gc, pack files, binary delta exclusioncrates/kiln-benchmarks/README.md— serves as the results document. Contains benchmark descriptions, scale targets, pre-populated results tables (to be filled in after a run), and a findings/recommendations section.Config changes
.config/release-please-config.json— addskiln-benchmarkswithpublish: false.config/release-please-manifest.json— adds initial version0.0.0.github/workflows/CD.yml— publishes onlygit-kiln(not the bench crate); adds abenchmarksjob that runscargo benchand uploadstarget/criterion/as a 90-day artifactVerification
The smoke test produced
~21 µsmean latency on an M-series Mac — well within the 5 ms target.