Add display_name to users table and propagate sender info through all handlers#2311
Merged
hiroshinishio merged 2 commits intomainfrom Feb 23, 2026
Merged
Add display_name to users table and propagate sender info through all handlers#2311hiroshinishio merged 2 commits intomainfrom
hiroshinishio merged 2 commits intomainfrom
Conversation
…ough all handlers - Rename get_user_public_email to get_user_public_info, return UserPublicInfo dataclass with email and display_name - Add display_name (required) to upsert_user and create_user_request - Add sender_display_name to BaseArgs, populate from get_user_public_info in all handlers - Title-case display names that are all lowercase or all uppercase - Fix check_suite_handler and review_run_handler to call get_user_public_info instead of hardcoding fake emails - Type user_data as dict[str, str | None] to fix Any propagation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_user_public_emailtoget_user_public_info, returning aUserPublicInfodataclass with bothemailanddisplay_namedisplay_name(required, no default) toupsert_userandcreate_user_requestsender_display_nametoBaseArgsand populate it fromget_user_public_infoin all three handlers (new_pr_handler,check_suite_handler,review_run_handler)check_suite_handlerandreview_run_handlerto callget_user_public_infofor real email/display_name instead of hardcoding fake noreply emails and empty stringsuser_dataasdict[str, str | None]to fixAnytype propagation fromresponse.json()