Fix all-None coverage treated as 100% in schedule handler#2313
Merged
hiroshinishio merged 1 commit intomainfrom Feb 24, 2026
Merged
Fix all-None coverage treated as 100% in schedule handler#2313hiroshinishio merged 1 commit intomainfrom
hiroshinishio merged 1 commit intomainfrom
Conversation
Files never measured by the coverage tool (all three metrics None) were incorrectly skipped as "fully covered". Now only files with at least one actual 100% metric and the rest None/100% are skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
None) were incorrectly skipped as "fully covered" in the schedule handler's candidate filteringweb/pickup/finishp.phphadstmt=None, func=None, branch=Noneand was silently excluded before even becoming a candidateNonecoverage values without crashing (TypeError: '>' not supported between NoneType and int)Social Media Post (GitAuto)
Our test scheduler was silently skipping files that needed tests. The coverage tool returns None for files it never measured - and our filter logic treated all-None as "100% covered." One customer's PHP codebase had thousands of unmeasured files invisible to the scheduler. A three-line fix now distinguishes "never measured" from "fully covered."
Social Media Post (Wes)
Found a subtle bug in our coverage filtering. When a coverage tool doesn't measure a file at all, it returns None for every metric. Our code checked
all(v is None or v == 100)- which is True when everything is None. So unmeasured files looked fully covered and were skipped forever. Took an AWS log dive on a customer repo to spot it.