Skip to content

Fix missing reviewers on schedule-created PRs#2315

Merged
hiroshinishio merged 1 commit intomainfrom
wes
Feb 24, 2026
Merged

Fix missing reviewers on schedule-created PRs#2315
hiroshinishio merged 1 commit intomainfrom
wes

Conversation

@hiroshinishio
Copy link
Collaborator

Summary

  • Remove cast(BaseArgs, ...) from schedule handler; properly type and populate all required BaseArgs fields
  • Look up sender_email and sender_display_name via GitHub API (get_user_public_info + get_email_from_commits) instead of hardcoding None/""
  • Look up is_fork via new is_repo_forked() GitHub API call instead of hardcoding False
  • Add reviewers: [user_name] so schedule-created PRs get a reviewer assigned
  • Set is_automation=True since schedule is an automated trigger
  • Replace hardcoded "once a day at 00:00 UTC" message with dynamic link to triggers settings page
  • Change event field access from .get() to direct [] since all fields are required in the TypedDict
  • Set pr_number, pr_title, pr_body explicitly after create_pull_request call
  • Add is_repo_forked() function with 4 unit tests
  • Also updated EventBridge schedule for spiderplus to use correct user (Takamori-san)

…sage

- Remove cast, populate all BaseArgs fields with correct values
- Look up sender email/display_name via GitHub API instead of hardcoding
- Look up is_fork via GitHub API instead of hardcoding False
- Add reviewers (schedule user) to schedule-created PRs
- Set is_automation=True for schedule trigger
- Replace hardcoded "once a day at 00:00 UTC" with link to triggers settings
- Add is_repo_forked function with tests
@hiroshinishio hiroshinishio self-assigned this Feb 24, 2026
@hiroshinishio hiroshinishio changed the title Properly populate BaseArgs in schedule handler and fix automation message Fix missing reviewers on schedule-created PRs Feb 24, 2026
@hiroshinishio hiroshinishio merged commit df20960 into main Feb 24, 2026
1 check passed
@hiroshinishio hiroshinishio deleted the wes branch February 24, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant