Skip untestable files in new_pr_handler and close PR#2317
Merged
hiroshinishio merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__init__.pywith only a docstring), the agent now checksshould_skip_test()before proceedingshould_skip_pythonRoot cause
The dashboard allows users to select any file from the coverage table for test generation. Files like
__init__.pythat only contain a docstring passis_source_file()(because.pyextension) and enter the coverage DB. The agent then writes trivial tests liketest_package_is_importablethat add no value.Related finding
GA's
restrict_edit_to_target_test_file_only=Truepolicy prevents it from fixing implementation bugs it discovers. In joeHeld/Unit-Testing-Demo, GA found 4 bugs inlogic.pybut couldn't fix them - so it wrote tests matching the buggy behavior instead. Worth discussing whether coverage PRs should allow impl fixes when bugs are found.