Populate allowed_to_edit_files in check_suite and review handlers#2318
Merged
hiroshinishio merged 1 commit intomainfrom Feb 24, 2026
Merged
Populate allowed_to_edit_files in check_suite and review handlers#2318hiroshinishio merged 1 commit intomainfrom
hiroshinishio merged 1 commit intomainfrom
Conversation
When CI fails on a coverage PR, the agent discovers impl bugs but can't fix them because allowed_to_edit_files was empty. Now both handlers populate the allow list from PR changed files, validation errors, and (for check_suite) the impl file from the PR title.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allowed_to_edit_filesincheck_suite_handlerwith PR changed files, validation error files, and the impl file from the PR title - so the agent can fix impl bugs it discovers during CI retriesreview_run_handler- PR changed files and validation error files are now in the allow listtest_check_suite_handler.pyto use realistic GitAuto titles (e.g., "Low Test Coverage: src/main.py") instead of "Test PR"Social Media Post (GitAuto)
When GitAuto creates a test coverage PR and CI fails because the implementation has bugs, the agent reads the error logs, identifies the root cause - then gets blocked from fixing it. The permission model only allowed editing test files, not the buggy implementation. Now the check suite handler populates an allow list with the PR's changed files and the implementation file, so the agent can fix what it finds.
Social Media Post (Wes)
Debugging a customer's failing coverage PR. GitAuto wrote correct tests, CI failed, the agent retried - and the logs showed it correctly identified four bugs in the source file. But then it errored out trying to edit it. The safety guard that restricts edits to test files only was too strict for the retry scenario. The allow list mechanism was already there, just never populated in the retry handler. Seven lines fixed it.