Downgrade logger.error to logger.warning for server errors#2324
Merged
hiroshinishio merged 1 commit intomainfrom Feb 24, 2026
Merged
Downgrade logger.error to logger.warning for server errors#2324hiroshinishio merged 1 commit intomainfrom
hiroshinishio merged 1 commit intomainfrom
Conversation
…_generic_error Sentry's LoggingIntegration auto-captures ERROR-level logs as events, so logger.error() was sending server errors to Sentry even though capture_exception() was explicitly skipped for 5xx errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_handle_generic_errorinhandle_exceptions.pycorrectly skippedsentry_sdk.capture_exception()for 5xx server errors, but then calledlogger.error()unconditionallyLoggingIntegrationcaptures all ERROR-level logs as events, so server errors were still spamming Sentry (e.g. AGENT-26D, AGENT-2TW)logger.warning()for server errors so they're still visible in CloudWatch but no longer create Sentry events