Conversation
Signed-off-by: Logan Blyth <logan@githedgehog.com>
|
🚀 Deployed on https://preview-99--hedgehog-docs.netlify.app |
|
I am tempted to manual undo the formatting that creates the links to nowhere. But that isn't the right way to fix the problem. |
qmonnet
left a comment
There was a problem hiding this comment.
Looks good, but I see that you skipped the doc update from githedgehog/fabric@efd6264, is it intentional?
Yep, that's something we should ideally fix in the way we generate the doc; if there's no option to do that (I didn't manage to find one when looking this morning), then fallback on some additional generation step where we run some fix-up script, I guess. |
|
That was unintentional. I guess we have another fabric bump and tag coming. I took a quick look at it as well. I see places to exclude the field entirely from the docs, but we don't want to do that. I was thinking the other way to do it would be to add more info to the fabric repo so those links actually have a place to go. |
|
Good catch, it was changed after the release artifact |
|
Would it make sense to automatically create PRs in this repo with a GH Action when we push a tag on the fabric repo? |
|
Something like that in name: Update docs
on:
push:
tags:
- '*'
jobs:
copy-api-reference:
runs-on: ubuntu-latest
steps:
- name: Checkout "fabric" repository
uses: "actions/checkout@v4"
with:
fetch-depth: 0
persist-credentials: "false"
- name: Checkout "docs" repository
uses: "actions/checkout@v4"
with:
repository: githedgehog/docs
path: /documentation
persist-credentials: "false"
- name: Copy API reference from "fabric" to "docs"
run: |
cp docs/api.md /documentation/docs/reference/api.md
- name: Create Pull Request
uses: "peter-evans/create-pull-request@v7"
with:
token: ${{ secrets.DOCS_API_REF_UPDTATE_TOKEN }}
path: /documentation
commit-message: |
Update API reference from ${{ github.repository }} tag ${{ github.ref_name }}.
This is an automated commit created by GitHub Actions workflow,
in the "${{ github.repository }}" repository.
signoff: true
title: "Update API reference from ${{ github.repository }} tag ${{ github.ref_name }}"
body: |
Update API reference from ${{ github.repository }} tag ${{ github.ref_name }}.
This is an automated Pull Requesst created by GitHub Actions workflow,
in the "${{ github.repository }}" repository.(Not tested - And I don't think I have permission to create the relevant token.) |
closes https://github.com/githedgehog/internal/issues/122
Since @Frostman did the supported devices table