Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the CI workflow’s vlab reusable-workflow invocation to skip running the hybrid “hlab” matrix entry during certain non-PR runs.
Changes:
- Updates the
vlabjob’sskipexpression to additionally skip hybrid runs onpushevents.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ) | ||
| || github.event_name == 'push' && matrix.hybrid | ||
| }} |
There was a problem hiding this comment.
The added skip condition github.event_name == 'push' && matrix.hybrid will skip all hybrid runs on any push (including pushes to master / release/*), not just tag-triggered runs. If the intent is “temp skip hlab on tag jobs”, consider restricting this to tag refs (e.g., startsWith(github.ref, 'refs/tags/')) so branch pushes still exercise hlab when desired.
| ${{ | ||
| github.event_name == 'pull_request' | ||
| && ( | ||
| matrix.hybrid && !contains(github.event.pull_request.labels.*.name, 'ci:+hlab') | ||
| || !matrix.hybrid && contains(github.event.pull_request.labels.*.name, 'ci:-vlab') | ||
| ) && ( | ||
| matrix.upgradefrom == '' || contains(github.event.pull_request.labels.*.name, 'ci:-upgrade') | ||
| ) | ||
| || github.event_name == 'push' && matrix.hybrid | ||
| }} |
There was a problem hiding this comment.
The skip expression mixes && and || without explicit grouping, which is easy to misread and can lead to accidental logic changes later. Consider adding parentheses around each high-level clause (PR label-based clause vs push/tag clause) to make the intended precedence unambiguous.
|
🚀 Temp artifacts published: |
Signed-off-by: Sergei Lukianov <me@slukjanov.name>
Frostman
force-pushed
the
dev/frostman/tag-no-hlab
branch
from
ece8936 to
d5a937c
Compare
|
🚀 Temp artifacts published: |
No description provided.