Add dp-validator wasm-wasi based validation#1381
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an optional “dataplane validator” that is downloaded from an OCI registry and intended to be executed as a WASM/WASI module during Gateway admission validation.
Changes:
- Injects a
GatewayValidatorinto the Gateway webhook and runs it during create/update validation. - Introduces
GatewayValidatorthat downloadsvalidator.wasmvia ORAS and compiles it with wazero. - Refactors Gateway reconciler logic to build a
GatewayAgentvia a new helper and adds retry signaling.
Reviewed changes
Copilot reviewed 8 out of 366 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/ctrl/gateway_wh.go | Wires a GatewayValidator into Gateway admission create/update flows. |
| pkg/ctrl/gateway_valid.go | New WASM validator loader using ORAS + wazero runtime/module compilation. |
| pkg/ctrl/gateway_ctrl.go | Refactors GatewayAgent building into BuildGatewayAgent with retry behavior. |
| cmd/main.go | Initializes GatewayValidator, passes it to webhook, switches to ctx-driven lifecycle. |
| api/meta/types.go | Adds DataplaneValidatorRef config field. |
| config/manager/manager.yaml | Mounts a docker-config secret for ORAS credential resolution. |
| go.mod | Adds wazero dependency for WASM runtime. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🚀 Temp artifacts published: |
|
🚀 Temp artifacts published: |
Frostman
force-pushed
the
dev/frostman/gw-valid
branch
from
e1afa50 to
1d83a78
Compare
|
🚀 Temp artifacts published: |
|
🚀 Temp artifacts published: |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 369 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Frostman
force-pushed
the
dev/frostman/gw-valid
branch
from
27de1ba to
b0e88b5
Compare
|
🚀 Temp artifacts published: |
|
🚀 Temp artifacts published: |
Frostman
force-pushed
the
dev/frostman/gw-valid
branch
from
b0e88b5 to
4a96f5b
Compare
|
🚀 Temp artifacts published: |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 369 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Frostman
force-pushed
the
dev/frostman/gw-valid
branch
from
4a96f5b to
6a5688d
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 369 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Frostman
force-pushed
the
dev/frostman/gw-valid
branch
from
db2bcfd to
b14b7de
Compare
|
🚀 Temp artifacts published: |
Signed-off-by: Sergei Lukianov <me@slukjanov.name>
Signed-off-by: Sergei Lukianov <me@slukjanov.name>
Signed-off-by: Sergei Lukianov <me@slukjanov.name>
Signed-off-by: Sergei Lukianov <me@slukjanov.name>
Signed-off-by: Sergei Lukianov <me@slukjanov.name>
Signed-off-by: Sergei Lukianov <me@slukjanov.name>
Signed-off-by: Sergei Lukianov <me@slukjanov.name>
Signed-off-by: Sergei Lukianov <me@slukjanov.name>
Signed-off-by: Sergei Lukianov <me@slukjanov.name>
Signed-off-by: Sergei Lukianov <me@slukjanov.name>
Frostman
force-pushed
the
dev/frostman/gw-valid
branch
from
b14b7de to
d417ce7
Compare
|
🚀 Temp artifacts published: |
No description provided.