replace on-ready setup-vpcs / setup-peerings / test-connectivity with basic release test scenario by edipascale · Pull Request #1290 · githedgehog/fabricator

edipascale · 2026-01-07T16:51:35Z

edipascale · 2026-01-16T07:19:59Z

realized this doesn't cover gateway, which is added in the onReady setup-peerings if the gateway is enabled, so I gotta add at least that before this can get in. moving back to draft

edipascale · 2026-02-18T17:19:53Z

moving to draft as we discussed changes we want to make to extend the coverage of the test, specifically for VLAB

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Frostman · 2026-04-15T19:01:40Z

@claude review once

Frostman · 2026-04-15T19:45:37Z

@edipascale just trying claude code review...

Phase 4 was bundling JUnit XML per pair, NxN visualization, and tiered-test integration alongside matrix diff on failure. On re-examination only the diff materially improves triage: - JUnit XML per pair duplicates what rt_*.go's JUnitTestSuite already captures at the higher level; the failure string already lists failing pairs. - NxN visualization is readable at VLAB scale (N ~= 12) but falls over at release-test scale (N ~= 60 -> 3600 cells). The diff surfaces every useful signal on failure; a full-matrix render is redundant. Phase 4 now scopes to a single deliverable: render only the cells where expected != actual on a failed run, with the specific failure annotation. Revisit JUnit / NxN if PR #1290 or a concrete request proves a need. No code changes. Signed-off-by: Pau Capdevila <pau@githedgehog.com>

adapt to the new syntax for multi-vpcs, even though right now we keep supporting only a single vpc Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>

make it a special test which is only run if explicitly requested, disabling all other tests. the new test attempts to cover as much ground as possible given the limitations of virtual switches, and fails if any of the desired functionalities to test are not present or supported, to make sure we do not accidentally skip it and miss breaking changes. the only exception is that we must still support deployments with no gateway, so gateway peerings are skipped if it is not enabled. upgrade jobs still use the old setup as they do not support some of the things we need, such as static externals. Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>

e.g. do not spawn mclag or eslag leaves for l3vni, or increase orphan leaves for mesh to replace the missing mclag nodes Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>

Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>

since we currently do not exercise it due to the NAT issues with test connectivity. we can revert this commit and add the appropriate testing steps once we support it Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>

when picking the named external to use in release-tests. we will use external peerings with that external and proxied static external do not support those, as we need NAT Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>

fix release-test not being run on upgrade jobs if the input requires it, but also attempt to make it a little bit clearer by building the command via explicit if/else clauses Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>

Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>

edipascale force-pushed the ema/basic-rt-scenario branch from c2c7d6c to 8b473d9 Compare January 7, 2026 17:15

edipascale force-pushed the ema/release-test-reorg branch 2 times, most recently from 0c887ee to e3be2ee Compare January 13, 2026 16:43

Base automatically changed from ema/release-test-reorg to master January 14, 2026 01:09

edipascale force-pushed the ema/basic-rt-scenario branch from 8b473d9 to 0558c3c Compare January 14, 2026 13:33

edipascale marked this pull request as ready for review January 14, 2026 14:04

edipascale requested review from a team as code owners January 14, 2026 14:04

edipascale marked this pull request as draft January 16, 2026 07:20

edipascale force-pushed the ema/basic-rt-scenario branch 3 times, most recently from dd49b9f to 5762ffb Compare January 19, 2026 07:52

edipascale marked this pull request as ready for review January 19, 2026 17:47

edipascale force-pushed the ema/basic-rt-scenario branch from 5762ffb to 2e6a1d0 Compare February 10, 2026 16:01

edipascale requested a review from a team as a code owner February 10, 2026 16:01

edipascale force-pushed the ema/basic-rt-scenario branch from 2e6a1d0 to 0aa4220 Compare February 11, 2026 11:02

edipascale mentioned this pull request Feb 11, 2026

chore: no upgrades from 25.04 and no gw upgrades #1442

Merged

edipascale force-pushed the ema/basic-rt-scenario branch from 0aa4220 to 2346c5c Compare February 18, 2026 15:44

edipascale marked this pull request as draft February 18, 2026 17:19

Frostman requested changes Feb 19, 2026

View reviewed changes

Comment thread pkg/hhfab/rt_multi_vpc_multi_subnet_suite.go Outdated

edipascale force-pushed the ema/basic-rt-scenario branch 7 times, most recently from 63cfb04 to ac23915 Compare February 24, 2026 15:45

edipascale marked this pull request as ready for review February 24, 2026 16:44

Copilot AI reviewed Mar 10, 2026

View reviewed changes

Comment thread .github/workflows/run-vlab.yaml Outdated

Comment thread pkg/hhfab/rt_on_ready_suite.go

Comment thread pkg/hhfab/rt_multi_vpc_single_subnet_suite.go

Comment thread pkg/hhfab/rt_on_ready_suite.go

Comment thread pkg/hhfab/rt_base.go Outdated

edipascale force-pushed the ema/basic-rt-scenario branch from 84dbb27 to 07eeb10 Compare March 10, 2026 16:42

edipascale requested a review from pau-hedgehog March 10, 2026 17:35

edipascale force-pushed the ema/basic-rt-scenario branch from 07eeb10 to 777111b Compare March 11, 2026 08:50

pau-hedgehog previously approved these changes Mar 11, 2026

View reviewed changes

edipascale force-pushed the ema/basic-rt-scenario branch 3 times, most recently from 5946b3d to 9b4bcc0 Compare March 18, 2026 13:51

edipascale dismissed pau-hedgehog’s stale review via 53a377d March 23, 2026 08:06

edipascale force-pushed the ema/basic-rt-scenario branch 2 times, most recently from 53a377d to 8c94dbe Compare March 23, 2026 08:14

pau-hedgehog force-pushed the ema/basic-rt-scenario branch from 8c94dbe to 11d21ce Compare March 25, 2026 15:41

edipascale force-pushed the ema/basic-rt-scenario branch 2 times, most recently from ccc9950 to 2f340d7 Compare April 9, 2026 10:06

edipascale force-pushed the ema/basic-rt-scenario branch from 2f340d7 to dc696b0 Compare April 15, 2026 13:42

claude Bot reviewed Apr 15, 2026

View reviewed changes

Comment thread .github/workflows/run-vlab.yaml

Comment thread pkg/hhfab/rt_base.go Outdated

Comment thread pkg/hhfab/rt_on_ready_suite.go Outdated

edipascale force-pushed the ema/basic-rt-scenario branch from dc696b0 to 4cd98d7 Compare April 16, 2026 09:17

edipascale force-pushed the ema/basic-rt-scenario branch from 4cd98d7 to cc9c3d5 Compare April 22, 2026 07:41

edipascale added 8 commits April 24, 2026 17:04

fix: hostbgp netconf cmd

acc0f1c

adapt to the new syntax for multi-vpcs, even though right now we keep supporting only a single vpc Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>

chore(ci): parametrize vlab topo based on input

d908c64

e.g. do not spawn mclag or eslag leaves for l3vni, or increase orphan leaves for mesh to replace the missing mclag nodes Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>

chore(rt): skip external peerings with vs

b857426

Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>

chore: remove proxied external

4b3c3dd

since we currently do not exercise it due to the NAT issues with test connectivity. we can revert this commit and add the appropriate testing steps once we support it Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>

chore(rt): skip proxied static externals

b468843

when picking the named external to use in release-tests. we will use external peerings with that external and proxied static external do not support those, as we need NAT Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>

ci: untangle HHFAB test command

155181c

fix release-test not being run on upgrade jobs if the input requires it, but also attempt to make it a little bit clearer by building the command via explicit if/else clauses Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>

chore(rt): fix typo in variable name

e55cb21

Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>

edipascale force-pushed the ema/basic-rt-scenario branch from cc9c3d5 to e55cb21 Compare April 24, 2026 15:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

replace on-ready setup-vpcs / setup-peerings / test-connectivity with basic release test scenario#1290

replace on-ready setup-vpcs / setup-peerings / test-connectivity with basic release test scenario#1290
edipascale wants to merge 8 commits intomasterfrom
ema/basic-rt-scenario

edipascale commented Jan 7, 2026 •

edited

Loading

Uh oh!

edipascale commented Jan 16, 2026

Uh oh!

edipascale commented Feb 18, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Frostman commented Apr 15, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Frostman commented Apr 15, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

edipascale commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

edipascale commented Jan 16, 2026

Uh oh!

edipascale commented Feb 18, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Frostman commented Apr 15, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Frostman commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

edipascale commented Jan 7, 2026 •

edited

Loading

Frostman commented Apr 15, 2026 •

edited

Loading